Valkirie / HandheldCompanion

ControllerService
Other
1.15k stars 89 forks source link

Magpie/Lossless Scaling integration for Devices were AMD RSR is not working due do Portrait Resolutions #806

Open NightHammer1000 opened 10 months ago

NightHammer1000 commented 10 months ago

Describe the solution you'd like AMD RSR is apparently not working on Devices that have Native Portrait Resolutions like the OneXPlayer 2 Pro. The Driver Overlay always tell inactive because it is unable to detect the difference to the Native Resolution.

A Solution for such cases would be an Integration with Lossless Scaling or Magpie.

It would be cool to set its activation on a per game basis. Maybe with a setable delay to start the scaling

Describe alternatives you've considered Currently, I have set the Long Press of the Turbo Button to send the Hotkey for the Activation of Lossless Scaling. This works too. But Automatic Activation on a small delay would be nice.

Additional context I am willing to provide the Devs a Copy of Lossless Scaling via Steam Gift if necessary. Magpie itself is OpenSource: https://github.com/Blinue/Magpie

I personally find that Lossless Scalings "LS1" has the most clean Quality. And I generally find that using Magpie or Lossless Scaling generally produces a much better Image than RSR anyway.

CasperH2O commented 10 months ago

Something like this would indeed be nice. But now sure how to approach this from a technical perspective. They don't have an API I think.

There's also an open ticket where HC is not properly detecting Magpie upscaled games https://github.com/Valkirie/HandheldCompanion/issues/413 Lossless scaling games are detected though.

I also own a copy of Lossless Scaling, great little program.

NightHammer1000 commented 10 months ago

X86 Tuning Utility has integrated Magpie completly as it is Open Source.

Lossless Scaling supports App Profiles to Automatically start Upscaling. Those have to be saved somewhere. If we figure that out we could just add a Profile in Lossless Scaling once we enable it In HCs Profile for a Game.

gmartins-henrique commented 8 months ago

The profiles are inside a "Settings.xml" file on \AppData\Local\Lossless Scaling