Valkirie / HandheldCompanion

ControllerService
Other
1.18k stars 91 forks source link

Make HidHide (and possibly other programs) installation and dependant features optional #953

Open Metadorius opened 9 months ago

Metadorius commented 9 months ago

Is your feature request related to a problem? Please describe. Looking as there are still issues caused by HidHide when people softbrick the device through proper uninstallation (https://github.com/nefarius/HidHide/issues/131, https://github.com/Valkirie/HandheldCompanion/issues/946, https://github.com/Valkirie/HandheldCompanion/issues/817), I am totally not looking forward to a possibility of softbricking my device. I still want to try the application though, but it doesn't let me start without HidHide installed, even if I don't need the features it provides.

Describe the solution you'd like Make HC disable the features that depend on HidHide when it's not detected instead of failing to start. Same for other programs and make their installation optional, but HidHide first and foremost.

Describe alternatives you've considered Installing HidHide - no, I don't want to have a possibility of bricked device when I uninstall HidHide/HC.

CasperH2O commented 9 months ago

Thank you @Metadorius . While not an unreasonable request, it's definitely a high impact thing to realize this.

HidHide and Vigem, used for virtual controller type and hiding physical controllers, in HC used for gyro, layout remapping, various controller options RTSS, in HC used for OSD overlay and AutoTDP

Metadorius commented 9 months ago

Understandable. In the long run I think the modularity proposed will be a good thing moving forward, definitely beneficial for users who only wish to use a subset of features.