search

Valks-Games / sankari

A open source 2D platformer being made in Godot 4 beta C#
MIT License
62 stars 15 forks source link

Attempted to convert to new Callable in Godot 4 Beta 4 but got 2 errors #218

Closed valkyrienyanko closed 2 years ago

valkyrienyanko commented 2 years ago

I recently tried to convert to the new Callable used in Godot 4 Beta 4 (see https://github.com/Valks-Games/sankari/commit/fd78d2f96f91f60c2274d6d39ad509268e1ebe11)

But I ran into 2 errors when dashing in game. These methods are in MovingEntityCommandDash.cs in Initialize() method. (see https://github.com/Valks-Games/sankari/blob/godot4beta4/Scripts/Entities/Commands/MovingEntityCommandDash.cs)

image

What am I doing wrong here?

valkyrienyanko commented 2 years ago

Okay actually I see a problem, I create a new Callable with a target of Entity and methods that are not defined in Entity.

But it was working before?

valkyrienyanko commented 2 years ago

Commented out "OnDashDurationDone?.Invoke" but that does not seem to effect gameplay at all so going to roll with these changes 781c0ac2a28d8f1ce271b7eecf9a4a58bbb09d34