ValkyrienSkies / Eureka

Basically Archimedes Ships, but with VS2 as the backend
Apache License 2.0
56 stars 33 forks source link

PBR/POM textures don't render properly with shaders enabled #241

Open onecamband opened 1 year ago

onecamband commented 1 year ago

Mod Name

Iris + any shader that supports POM

This issue occurs when only Valkyrien Skies, addons, and the mod I have specified are installed and no other mods

Minecraft Version

1.19

Mod Loader

Fabric

Issue description

When assembling a ship with shaders enabled, rotating the ship too far away from its original position causes the inner layers of blocks using POM textures to stop rendering, allowing the player to see through the ship. I suspect that this has something to do with the "Shipyard" and/or texture mapping as it looks like the 3d textures only want to exist on the axis on which they were originally placed and after being rotated, they are no longer able to find their coordinates.

Issue reproduction

With both Eureka! and Iris installed, load a recourse pack that includes PBR/POM textures (I use AVPBR) and a shader pack that supports parallax occlusion mapping (I use SEUS PTGI) and assemble a ship. Turn the ship more that around 20 degrees in any direction and parts of the texture will begin to fall away from the surface of the block.

Logs

Not sure if logs will be helpful in this case but here they are regardless.

[13:27:11] [main/INFO]: Loading Minecraft 1.20.1 with Fabric Loader 0.14.21 [13:27:11] [ForkJoinPool-1-worker-12/WARN]: Mod explorify uses the version v1.3.0-mc1.20u1.20.1 which isn't compatible with Loader's extended semantic version format (Could not parse version number component 'v1'!), SemVer is recommended for reliably evaluating dependencies and prioritizing newer version [13:27:11] [main/INFO]: Loading 149 mods:

millennIumAMbiguity commented 1 year ago

I would say duplicate of https://github.com/ValkyrienSkies/Valkyrien-Skies-2/issues/556, but it appears that you don't crash, therefore giving the issue a value. I believe the issue is a VS2 issue.