search

ValkyrienSkies / Eureka

Basically Archimedes Ships, but with VS2 as the backend
Apache License 2.0
56 stars 33 forks source link

Dissasembling ship 90° to the right of the original orientation causes ship-ruining block rotation #271

Closed Ramelstag closed 5 months ago

Ramelstag commented 11 months ago

This issue occurs when only Valkyrien Skies and addons are installed and no other mods

Minecraft Version

1.20​

Mod Loader

Forge

Issue description

Hi, I'm sure others have reported this issue, but just in case I'm reporting extra information about the issue which may not have been reported before. For example, you assemble a ship that is facing north, and, you disassemble the ship when it is facing east, and east only, the ship will have it's fences, torches, stairs, and other blocks with rotation metadata rotated. This can fortunately be fixed by doing the exact same thing again, re-assemble, and face south since the ship was facing east, and the blocks will rotate again, usually to their original rotation, fixing the damage, but I wouldn't count on it. The same behavior can be found in the 1.18 and 1.19 versions. Here's an example video: (instance in the video is 1.19.2 but the behavior is exactly the same in 1.20.1

https://imgur.com/a/apDm3fb

WORKAROUND IDEA: Make the mod remember which direction it was facing when assembled (possibly using the helm block's rotation metadata?), and, when the player hits the disassemble button, if possible, check if the current direction is 90° to the right of the original, and if it is, it tells the player that it cannot be disassembled to that direction, instead of disassembling. I have yet to become a competent programmer so I can't try this workaround idea myself unfortunately.

Issue reproduction

1: Assemble ship 2: Rotate it 90° to the right (i.e, turn towards east if it was facing north when assembled) 3: Disassemble. Doing it again can fix the damage done to the ship.

Logs

debug.log latest.log

PriestOfFerns commented 11 months ago

Known issue, also 1.18 is the only really maintained version of VS2, with 1.19 and 1.20.1 only having been updated some months ago

millennIumAMbiguity commented 5 months ago

Duplicate of #185