ValkyrienSkies / Eureka

Basically Archimedes Ships, but with VS2 as the backend
Apache License 2.0
56 stars 33 forks source link

[ SUGGESTION ] Implement Interface class to ENUM class #407

Open Xelbayria opened 5 days ago

Xelbayria commented 5 days ago

Mod Name

Every Compat

This issue occurs when only Valkyrien Skies, addons, and the mod I have specified are installed and no other mods

Minecraft Version

1.18

Mod Loader

Forge

Eureka version

latest version via Github

Issue description

I'm a DEV adding a mod to Every Compat. so it can generate variant helm with Wood Mods (Biomes O' Plenty & Others)

The issue is that I cannot add the support because of WoodType.kt is an ENUM class.

I noticed a comment was left "// TODO mod compat". Every Compat will take care of it for any Wood Mods. No need to worry about this.

This is applied to 1.20.1, too.

SOLUTION:

You can use Interface class to implement IWoodType.kt to the WoodType.kt. Here's an good example from a mod, Function Storage

I had no problem supporting the mod via Every Compat. I hope it's not much of work for you to implement.

Issue reproduction

n/a

Logs

No response

millennIumAMbiguity commented 1 day ago

👀

millennIumAMbiguity commented 17 hours ago

I made the changes you mentioned in a draft but I don't know if it is sufficient as the models are not created at runtime but listed in assets. common/src/main/resources/assets/vs_eureka/blockstates common/src/main/resources/assets/vs_eureka/models/block

I believe that the modals can and should be registered runtime to improve compact.