search

ValkyrienSkies / Valkyrien-Skies-2

Valkyrien Skies 2
https://valkyrienskies.org/
GNU Lesser General Public License v3.0
223 stars 97 forks source link

Dungeon Gear mixin incompatibility 1.16.5 #232

Open SweetestBoy opened 1 year ago

SweetestBoy commented 1 year ago

I really want to use Dungeons Gear, Valkyrien Skies, and Eureka! Airships. I have all the dependents that are required by each mod. I have ran each mod independently without issue. The issue arises when starting an instance of minecraft with Dungeons Gears and Valkyrien Skies, though Eureka! Airships is dependent on Valkyrien Skies, it causes the game to crash without creating a crash log. I have enabled the game output to see what is causes the wrench being thrown. I am curious as to if these mods will possibly be compatible in the future or if your mod relies on a mix-in that is being modified by the other mod. Here is the game output that states the issues:

[11:58:18] [main/WARN] [mixin/]: @reDIrect conflict. Skipping dungeons_gear.mixins.json:GameRendererMixin->@reDIrect::getModifiedDistance1(Lnet/minecraft/util/math/vector/Vector3d;Lnet/minecraft/util/math/vector/Vector3d;)D with priority 1000, already redirected by valkyrienskies-common.mixins.json:client.renderer.MixinGameRenderer->@reDIrect::correctDistanceChecks(Lnet/minecraft/util/math/vector/Vector3d;Lnet/minecraft/util/math/vector/Vector3d;)D with priority 1000

[11:58:18] [main/WARN] [mixin/]: @reDIrect conflict. Skipping dungeons_gear.mixins.json:GameRendererMixin->@reDIrect::getModifiedDistance2(Lnet/minecraft/util/math/vector/Vector3d;Lnet/minecraft/util/math/vector/Vector3d;)D with priority 1000, already redirected by valkyrienskies-common.mixins.json:client.renderer.MixinGameRenderer->@reDIrect::correctDistanceChecks(Lnet/minecraft/util/math/vector/Vector3d;Lnet/minecraft/util/math/vector/Vector3d;)D with priority 1000

[11:58:18] [main/INFO] [STDERR/]: [java.lang.Throwable:printStackTrace:667]: Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Redirector getModifiedDistance1(Lnet/minecraft/util/math/vector/Vector3d;Lnet/minecraft/util/math/vector/Vector3d;)D in dungeons_gear.mixins.json:GameRendererMixin failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap dungeons_gear.refmap.json

Rubydesic commented 1 year ago

Wouldn't really call either mod 'causing the issue', both are. Thanks for the report. We should probably use MixinExtras to avoid this sort of issue.

SweetestBoy commented 1 year ago

Thank you, I posted it to GitHub of the other mod, and both of you have responded. Here is the link to see what is going there, https://github.com/Thelnfamous1/Dungeons-Gear/issues/173 Thank you again!

SweetestBoy commented 1 year ago

Any updates for the resolution or eta on it?

SweetestBoy commented 1 year ago

This question differs from the question above, but I have seen that Dungeon Gear is marked as incompatible on your wiki with low importance. Does this mean there will not be a fix, or if a fix does become available it will take much longer for it to be a focused to be worked on? Your reply can close with comment if you wish with however you reply.