ValkyrienSkies / Valkyrien-Skies-2

Valkyrien Skies 2
https://valkyrienskies.org/
GNU Lesser General Public License v3.0
237 stars 103 forks source link

Getting constant errors in console about "Collision Box is too big!" #320

Open sosigman23 opened 1 year ago

sosigman23 commented 1 year ago

As the title said, i'm getting constant errors about collision box being too big (?) I have an few other mods, which are: SecurityCraft Balm Chisels and Bits Create Eureka Flywheel FramedBlocks JEI KotlinForForge Valkyrien Skies I'm on version 1.18.2, if that matters.

walksanatora commented 1 year ago

i mean it is a constant error but it is very common and has no harm (from my expierence)

sosigman23 commented 1 year ago

i mean it is a constant error but it is very common and has no harm (from my expierence)

Well, another issue with it is that i just cannot move with the ship.

walksanatora commented 1 year ago

you sure you aren't in cruise controll/allignment mode

walksanatora commented 1 year ago

i get the feeling i should PR something to eureka that lets you know that Cruise/Allign is enabled

FetteKartoffel commented 1 year ago

Also getting the same issue. It appears to be assembling for a second but then almost instantly turns back into blocks which are immovable.

walksanatora commented 1 year ago

are you sure you dont have cruise controll enabled because that flash indicates that a ship has been formed

FetteKartoffel commented 1 year ago

are you sure you dont have cruise controll enabled because that flash indicates that a ship has been formed

Yeah I checked after seeing your previous comment. It also doesnt fall into the water when building it in the air, it just doesnt move at all.

weeryan17 commented 1 year ago

I'm getting the same issues, looks to just be a problem if your airship is too big. I also noticed in the message returning empty list! this might break things it sounds like if VS can't calculate collisions it prevents airships from moving probably for safety reasons so the airships don't embed themselves underground. Which is a bit of a bummer as I like my big airships.

weeryan17 commented 1 year ago

Looks like the limits are currently hard-coded at 1000x1000x1000 image

weeryan17 commented 1 year ago

hmm need to do more research as my airship is only ~250 blocks in its longest direction right now. either way looks like we're running into hard coded limits

FetteKartoffel commented 1 year ago

hmm need to do more research as my airship is only ~250 blocks in its longest direction right now. either way looks like we're running into hard coded limits

I tested it with a tiny creation which also didnt work so I don't think it's that.

littlej541 commented 1 year ago

I looked into this and it seems to be a line in Player::aiStep. It takes the vehicle AABB and the player AABB and performs an operation AABB::minmax to get the maximum bounding box containing the player and vehicle. However, since the VS2 ships are actually waaaay off in some chunks past the edge of the map, the ships bounding box position values are some huge numbers.

Because of this, taking the minmax of the player and ship bounding boxess create a massive bounding box stretching from the player to the off map ship. This AABB is then passed to Level::getEntities where a mixin from VS2 MixinLevel::check2 spits out the error when it notices the massive bounding box.

The only thing I'm not seeing currently is why it even gets into getEntities. There is another mixin from VS2 MixinPlayer::redirectAiStep that basically blocks the call to getEntities if the player is driving a ship.

BitSparks commented 7 months ago

hmm need to do more research as my airship is only ~250 blocks in its longest direction right now. either way looks like we're running into hard coded limits

did you find anything? ive also noticed that it can spawn the ship once assembled. However by the looks of it, blocks that are outside of the Hit box are glitched with that one side of the block being completly invisable. however everything works just fine. is very annoying and i looked at the server logs and it too keeps saying this... image

DuendeInexistente commented 2 months ago

Having the same issue. My modlist is

 alexscaves-1.1.5.jar
 alexsmobs-1.22.9.jar
 BiomeParticleWeather-v4.1.0-1.20.1-Forge.jar
 botany_fields-A0.2-forge-1.20.1.jar
 canary-mc1.20.1-0.3.3.jar
 cccbridge-mc1.20.1-forge-1.6.3.jar.disabled
 cc-tweaked-1.20.1-forge-1.113.1.jar
 cc_vs-1.20.1-forge-0.1.0.jar
 cenozoicraft-1.3.0-forge-1.20.1.jar
 citadel-2.6.0-1.20.1.jar
 clockwork-1.20.1-0.1.16-forge-b3b22e39fe.jar
 collective-1.20.1-7.84.jar
 Corgilib-Forge-1.20.1-4.0.3.2.jar
 CraterLib-Forge-1.20-2.1.0.jar
 create-1.20.1-0.5.1.h.jar
 create_connected-0.8.2-mc1.20.1-all.jar
 createdieselgenerators-1.20.1-1.2i.jar
 cullleaves-forge-3.2.0.jar
 curios-forge-5.10.0+1.20.1.jar
 dynamiccrosshair-7.4.4+1.20-forge.jar
 dynamic-fps-3.7.1+minecraft-1.20.0-forge.jar
 dynamiclights-v1.8.3-mc1.17x-1.21x-mod.jar
 eccentrictome-1.20.1-1.10.2.jar
 embeddium-0.3.31+mc1.20.1.jar
 eureka-1201-1.5.1-beta.3.jar
 geckolib-neoforge-1.20.1-4.4.9.jar
 GeckoLibOculusCompat-Forge-1.0.1.jar.disabled
 interiors-0.5.6+forge-mc1.20.1-build.104.jar
 invtweaks-1.20.1-1.1.0.jar
 jei-1.20.1-forge-15.19.0.88.jar
 JustEnoughResources-1.20.1-1.4.0.247.jar
 Kiwi-1.20.1-Forge-11.8.20.jar
 kotlinforforge-4.11.0-all.jar
 midnightlib-forge-1.4.2.jar
 noisium-forge-2.3.0+mc1.20-1.20.1.jar
 oculus-mc1.20.1-1.7.0.jar.disabled
 Oh-The-Biomes-Weve-Gone-Forge-1.2.3.jar
 Oh-The-Trees-Youll-Grow-forge-1.20.1-1.3.0.jar
 PassableFoliage-1.20.1-forge-8.2.1.jar.disabled
 polymorph-forge-0.49.5+1.20.1.jar
'Prehistoric world beta 0.1.5.jar'
 shetiphiancore-forge-1.20.1-1.3.jar
 SimpleRPC-Universal-3.3.3.jar
 spark-1.10.53-forge.jar
 Steam_Rails-1.6.5+forge-mc1.20.1.jar
 TerraBlender-forge-1.20.1-3.0.1.7.jar
 terraqueous-forge-1.20.1-1.4.jar
 THT-Forge-1.20.1-6.2.7.1.jar
 trackwork-1.20.1-1.0.1-beta.jar
 treeharvester-1.20.1-9.1.jar
 TSKimiSeiranFruitWine-Forge-1.20.1-1.9.jar
 valkyrienrelogs-0.1.3-forge.jar
 valkyrienskies-120-2.3.0-beta.5.jar
 VMod-Forge-1.20.1-0.0.11.jar
viscoci commented 1 month ago

Seeing this on fabric too and it related to a server crash a few times. One of my players worked with me to figure it out some, they disassembled their ship and the server stopped lagging, logs stopped obviously.

The ship in question is 9 blocks total. Ever since we increased the memory from 8gb to 16gb the logs still occur but it is no longer crashing the server, at least while testing by myself. I'll see what happens when other people are on later and the memory is reaching its limit.

We do have a lot of mods so not real surprised its not working for us perfectly.

MC - 1.20.1 Fabric Loader - 0.16.7

Mod list:

AmbientSounds_FABRIC_v6.1.1_mc1.20.1.jar
architectury-9.2.14-fabric.jar
athena-fabric-1.20.1-3.1.2.jar
AttributeFix-Fabric-1.20.1-21.0.4.jar
Axiom-2.5.0-for-MC1.20.1.jar
Axiom-4.1.1-for-MC1.20.1.jar
azurelib-fabric-1.20.1-2.0.39.jar
bellsandwhistles-0.4.5+1.20.1-FABRIC.jar
better-clouds-1.3.16+1.20.1.jar
BetterAnimationsCollection-v8.0.0-1.20.1-Fabric.jar
betterchunkloading-fabric-1.20.1-4.5.jar
BetterThirdPerson-Fabric-1.20-1.9.0.jar
Bookshelf-Fabric-1.20.1-20.2.13.jar
botarium-fabric-1.20.1-2.3.4.jar
cardinal-components-api-5.2.2.jar
cc-tweaked-1.20.1-fabric-1.113.1.jar
cccbridge-mc1.20.1-fabric-v1.6.2b.jar
chat_heads-0.13.3-fabric-1.20.jar
Chipped-fabric-1.20.1-3.0.6.jar
chipped-fabric-1.20.1-3.0.7.jar
chunksending-fabric-1.20.1-2.8.jar
Chunky-1.3.146.jar
ChunkyBorder-1.1.53.jar
clockwork-1.20.1-0.1.16-fabric-b3b22e39fe.jar
cloth-config-11.1.136-fabric.jar
Clumps-fabric-1.20.1-12.0.0.4.jar
comforts-fabric-6.4.0+1.20.1.jar
configured-fabric-1.20.1-2.2.3.jar
copycats-2.1.4+mc.1.20.1-fabric.jar
create_jetpack-fabric-4.2.0.jar
create-fabric-0.5.1-f-build.1417+mc1.20.1.jar
create-new-age-fabric-1.20.1-1.1.2.jar
createaddition-fabric+1.20.1-1.2.4.jar
createbigcannons-5.5.1-mc.1.20.1-fabric.jar
createchunkloading-1.6.0-fabric.jar
createdeco-2.0.2-1.20.1-fabric.jar
CreativeCore_FABRIC_v2.12.14_mc1.20.1.jar
cristellib-1.1.5-fabric.jar
cupboard-fabric-1.20.1-2.7.jar
EnchantmentDescriptions-Fabric-1.20.1-17.1.18.jar
eureka-1201-1.5.1-beta.3.jar
ExtendedDrawers-2.1.1+mc.1.20.1.jar
fabric-api-0.92.2+1.20.1.jar
fabric-language-kotlin-1.12.3+kotlin.2.0.21.jar
FarmersDelight-1.20.1-2.1.6+refabricated.jar
ForgeConfigAPIPort-v8.0.0-1.20.1-Fabric.jar
framework-fabric-1.20.1-0.7.11.jar
geckolib-fabric-1.20.1-4.4.9.jar
GeckoLibIrisCompat-Fabric-1.0.0.jar
handcrafted-fabric-1.20.1-3.0.6.jar
ImmediatelyFast-Fabric-1.2.21+1.20.4.jar
indium-1.0.34+mc1.20.1.jar
InventorySorter-1.9.0-1.20.jar
iris-1.7.5+mc1.20.1.jar
iris-flywheel-compat-fabric1.20.1+1.1.4.jar
Jade-1.20-fabric-11.11.0.jar
JadeAddons-1.20.1-Fabric-5.3.1.jar
jei-1.20.1-fabric-15.20.0.104.jar
JustEnoughResources-Fabric-1.20.1-1.4.0.247.jar
lithium-fabric-mc1.20.1-0.11.2.jar
mcw-bridges-3.0.0-mc1.20.1fabric.jar
mcw-doors-1.1.1fabric-mc1.20.1.jar
mcw-fences-1.1.2-mc1.20.1fabric.jar
mcw-furniture-3.3.0-mc1.20.1fabric.jar
mcw-lights-1.1.1-mc1.20.1fabric.jar
mcw-paintings-1.0.5-1.20.1fabric.jar
mcw-paths-1.0.5-1.20.1fabric.jar
mcw-roofs-2.3.1-mc1.20.1fabric.jar
mcw-trapdoors-1.1.3-mc1.20.1fabric.jar
mcw-windows-2.3.0-mc1.20.1fabric.jar
midnightlib-fabric-1.4.1.jar
mobs_of_mythology-fabric-1.20.1-2.0.3.jar
moremobvariants-fabric+1.20.1-1.3.1.jar
MouseTweaks-fabric-mc1.20-2.26.jar
Multiworld-Fabric-bundle.jar
naturalist-fabric-4.0.3-1.20.1.jar
NaturesCompass-1.20.1-2.2.3-fabric.jar
notenoughanimations-fabric-1.7.6-mc1.20.1.jar
nyfsspiders-fabric-1.20.1-2.1.1.jar
Patchouli-1.20.1-84-FABRIC.jar
PuzzlesLib-v8.1.24-1.20.1-Fabric.jar
refurbished_furniture-fabric-1.20.1-1.0.6.jar
resourcefullib-fabric-1.20.1-2.1.29.jar
skinlayers3d-fabric-1.6.7-mc1.20.1.jar
SmartBrainLib-fabric-1.20.1-1.15.jar
smoothchunk-fabric-1.20.1-3.6.jar
sodium-fabric-0.5.11+mc1.20.1.jar
sophisticatedbackpacks-1.20.1-3.20.11.26.jar
sophisticatedcore-1.20.1-0.6.33.31.jar
spark-1.10.53-fabric.jar
Steam_Rails-1.6.4+fabric-mc1.20.1.jar
tectonic-fabric-1.20.1-2.4.1b.jar
Terralith_1.20.x_v2.5.4.jar
Towns-and-Towers-1.12-Fabric+Forge.jar
travelersbackpack-fabric-1.20.1-9.1.18.jar
valkyrienskies-120-2.3.0-beta.5.jar
worldedit-mod-7.2.15.jar
Xaeros_Minimap_24.5.0_Fabric_1.20.jar
XaerosWorldMap_1.39.0_Fabric_1.20.jar

9 block ship