ValkyrienSkies / Valkyrien-Skies-2

Valkyrien Skies 2
https://valkyrienskies.org/
GNU Lesser General Public License v3.0
227 stars 99 forks source link

[1.16.5 Mixin Crash] Incompat with Shoulder Surfing - Cannot guarantee modifyCrosshairTargetEntities is redirectable #366

Open Kaleidio opened 1 year ago

Kaleidio commented 1 year ago

Definitely a conflict

https://pastebin.com/KQTx1eVm

Kaleidio commented 1 year ago

the conflict is with the Shoulder Surfing mod, as it modifies the player raytrace on the client side to pull off the over the shoulder changes it wants. Since your mod wishes to do the same thing, you aren't allowed to redirect it in this case. Consider a solution that avoids using redirectors, might be relevant to other "crosshair incorrect" issues on this repo

Rubydesic commented 1 year ago

This is fixed in 1.18, you may backport the fix (using MixinExtras) yourself if you wish. Otherwise I may get around to it later

Kaleidio commented 1 year ago

Sadly I'm busy with university so I wish not to dive into more than one mod to work on at a time, beyond the multiple projects uni gives me, but I will keep track of this issue for the fix. Hope to implement it in my pack soon

Volume70 commented 1 year ago

I literally just made an account so i can be notified when this fix goes out, if it does. otherwise I love the work that's been done with this mod, i never thought it'd be possible haha