ValkyrienSkies / Valkyrien-Skies-2

Valkyrien Skies 2
https://valkyrienskies.org/
GNU Lesser General Public License v3.0
205 stars 77 forks source link

Compatibility with WaterFrames #843

Open SrRapero720 opened 1 month ago

SrRapero720 commented 1 month ago

Mod Name

WaterFrames

This issue occurs when only Valkyrien Skies, addons, and the mod I have specified are installed and no other mods

Minecraft Version

1.20.x

Mod Loader

Forge

Issue description

Mod renders perfectly fine the pictures on ships. Whoever I received a tons of reports about displays have no sound.

WaterFrames/WaterMedia have not openAL integration yet (due some limitations). So we use DirectSound to manage the audio + check the player and block position every tick

The displays ticker refreshes the blockpos and calculates the volume based on the player distance

I assume the issue comes when the ship is relocated to the ship yard and the blockpos is taken from the shipyard instead of the relative blockpos

I vaguely remember sound works on older versions of VS? Last time I tested it sound was working on 1.18.2

Issue reproduction

Put a frame on a ship Assemble it Open the frame and play a video Video with no sound

Logs

Irrelevant