ValkyrienSkies / Valkyrien-Skies-2

Valkyrien Skies 2
https://valkyrienskies.org/
GNU Lesser General Public License v3.0
234 stars 102 forks source link

Incompatibility with worldgen mods (Tectonic + Wyther's Expanded Ecosphere)<title> #862

Open alejandrorusso4 opened 6 months ago

alejandrorusso4 commented 6 months ago

Mod Name

Tectonic, Expanded Ecosphere

This issue occurs when only Valkyrien Skies, addons, and the mod I have specified are installed and no other mods

Minecraft Version

1.20.x

Mod Loader

Fabric

Issue description

When Tectonic, WWOO, or both mods are installed, assembling a ship causes it to disappear (sometimes). More mods makes the probability of this higher. I tested it with just Tectonic and just WWOO and the ship would assemble fine the first couple of times, then disappear immediately after clicking on Assemble.

Also, not sure how related this is but on the debug stats it says the VS PhysTPS is 0, when it should be 60

Issue reproduction

Install VS and addons, install Tectonic. Config enable "increased_height":true. Install Expanded Ecospheres. Build and assemble ship

Logs

No response

Syclusion commented 5 months ago

My guess would be it is trying to assemble a GIANT ship based on the extra worldgen (hence why its seemingly randomized bc of the variance of terrain) maybe limiting worldgen to a specific height in the shipyard could fix it?

alejandrorusso4 commented 5 months ago

It does seem to be a world height issue. Worldgen mods with vanilla world height get this issue less frequently than those that increase the build height dramatically

PriestOfFerns commented 5 months ago

I think this is just an issue with vs2 1.20 being buggy, No relation to world gen mods. An easy way to prove that would be to look at 1.18, where this issue never happens, despite having more or less the same mods

Syclusion commented 5 months ago

I think this is just an issue with vs2 1.20 being buggy, No relation to world gen mods. An easy way to prove that would be to look at 1.18, where this issue never happens, despite having more or less the same mods

Considering I've been using 1.20 for awhile now and have had no issues like this. It's doubtful lol. I tried changing the settings in tectonic and instantly ran into this crash. It's 100% worldgen being screwed up

PriestOfFerns commented 5 months ago

@Syclusion did the ship you assembled have wings on it

Syclusion commented 5 months ago

@Syclusion did the ship you assembled have wings on it

No. Was a piece of wanderlight ore being interacted with.

PriestOfFerns commented 5 months ago

I'd be surprised if tectonic somehow caused issues with VS2 ships, and only on 1.20.1, but ig it's possible.

Either way most of this is anecdotal and not really reproducible. And tectonic is popular enough that most modpacks include it, so it's quite hard to blame it specifically

Syclusion commented 5 months ago

I'd be surprised if tectonic somehow caused issues with VS2 ships, and only on 1.20.1, but ig it's possible.

Either way most of this is anecdotal and not really reproducible. And tectonic is popular enough that most modpacks include it, so it's quite hard to blame it specifically

Change the config and it'll happen. Took 3 minutes to reproduce, this isn't stock tectonic the config matters.

Syclusion commented 5 months ago

It's less tectonic being at fault and more vs2 being unable to account for generation beyond default values imho

alejandrorusso4 commented 5 months ago

It also occurs when changing world height/messing with settings with ReTerraforged On Jun 27, 2024 at 5:29 PM -0400, Syclusion @.***>, wrote:

It's less tectonic being at fault and more vs2 being unable to account for generation beyond default values imho — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

PriestOfFerns commented 5 months ago

It's less tectonic being at fault and more vs2 being unable to account for generation beyond default values imho

"Vs2 being unable to account for generation beyond default values" usually just leads to terrain generating in the shipyard, causing ships to be made with entire chunks of terrain on them, not ships disappearing somehow.

Either way 1.20 VS2 has it's own large share of bugs, a lot of which can easily lead to ships "disappearing" (Example), so I find it a bit tough to believe that it has something to do with terrain generation mods, which already work on 1.18. At the very least you need a list of what config values cause issues, rather than just "something in config breaks mod", in order to verify this as an issue and get it fixed

Syclusion commented 5 months ago

It's less tectonic being at fault and more vs2 being unable to account for generation beyond default values imho

"Vs2 being unable to account for generation beyond default values" usually just leads to terrain generating in the shipyard, causing ships to be made with entire chunks of terrain on them, not ships disappearing somehow.

Either way 1.20 VS2 has it's own large share of bugs, a lot of which can easily lead to ships "disappearing" (Example), so I find it a bit tough to believe that it has something to do with terrain generation mods, which already work on 1.18. At the very least you need a list of what config values cause issues, rather than just "something in config breaks mod", in order to verify this as an issue and get it fixed

They aren't disappearing, vs2 tps tanks and crashes the client because it's doing exactly that, trying to assemble giant chunks of terrain

Syclusion commented 5 months ago

Also he already provided the config value that breaks it lol.

increased_height:true in tectonic

AgentMelinda commented 2 months ago

?

thetheaplant commented 2 months ago

? @AgentMelinda The issue and what breaks it is well explained, what further information do you need