ValkyrienSkies / Valkyrien-Skies-2

Valkyrien Skies 2
https://valkyrienskies.org/
GNU Lesser General Public License v3.0
207 stars 84 forks source link

Copycats+ boards have different collision than carpets, even though they have the same dimensions. #877

Open Tornc opened 2 weeks ago

Tornc commented 2 weeks ago

Mod Name

Copycats+

This issue occurs when only Valkyrien Skies, addons, and the mod I have specified are installed and no other mods

Minecraft Version

1.18

Mod Loader

Forge

Issue description

https://github.com/ValkyrienSkies/Valkyrien-Skies-2/assets/110984950/df562f6f-7e8f-4cf3-bf8c-bac58b81a70a

Entire modlist: explorer_eA3DDry1x5

Every mod config setting is default.

Relevant mods:

Issue reproduction

Place a phys bearing facing upwards, make the phys entity/ship attached to it rotate. On the same level, place carpets, they will get ignored by the phys entity/ship when it goes over the carpets. If boards are placed instead, they will collide and the phys entity will stop.

Logs

No response

thetheaplant commented 2 weeks ago

Is the collision box of the panels a full block or just their visible shape? If they are not a full block, then this was probably intentional.

Tornc commented 2 weeks ago

Sorry, I'm not entirely sure what you mean by collision box. Could you please elaborate? Though, I'm pretty sure that this behaviour was not intentional on the Copycats+ mod developers' end. (If you meant that)

Here's a conversation I had with one of the Copycats+ devs: image I then asked if I should report it to VS github instead. image

Rubydesic commented 2 weeks ago

VS uses BlockState#getShape to determine the shape of a blockstate, which is I think pretty standard? Not sure what a multistate is.