ValkyrienSkies / Valkyrien-Skies-2

Valkyrien Skies 2
https://valkyrienskies.org/
GNU Lesser General Public License v3.0
227 stars 99 forks source link

Game doesn't launch with VS dependency in dev environment #902

Open slava110 opened 4 months ago

slava110 commented 4 months ago

This issue occurs when only Valkyrien Skies and addons are installed and no other mods

Minecraft Version

1.20.x

Mod Loader

Forge

Issue description

Hi. I'm trying to add this mod as dependency to my project. However, I'm getting a error when I'm launching my game java.lang.ClassNotFoundException: org.valkyrienskies.core.api.world.ShipWorld I'm using Architectury Loom with only forge platform (no common subproject) Architectury Loom: 1.6-SNAPSHOT Forge: 1.20.1-47.1.47 Kotlin for Forge: 4.11.0 VSCore: 1.1.0+ VS2: 2.3.0-beta.5+ My dependencies block:

val vs_core_version = "1.1.0+"
val vs2_version = "2.3.0-beta.5+"

modApi("org.valkyrienskies:valkyrienskies-1201-forge:${vs2_version}") { isTransitive = false }

implementation("org.valkyrienskies.core:api:${vs_core_version}")
implementation("org.valkyrienskies.core:api-game:${vs_core_version}")
implementation("org.valkyrienskies.core:util:${vs_core_version}")
implementation("org.valkyrienskies.core:impl:${vs_core_version}")

I took it from https://github.com/ValkyrienSkies/Eureka/blob/0044230de56422aae08c2c483487d346d2068759/forge/build.gradle#L57-L62

Tried changing modApi to modCompileOnly, changing implementation to compileOnly and forgeRuntimeLibrary (throws error about Java modules). Nothing works

Issue reproduction

Architectury loom project with only forge platform and these dependencies (VS, Kotlin for Forge). I can provide sample if needed for reproduction

Logs

latest.log debug.log