ValkyrienSkies / Valkyrien-Skies-2

Valkyrien Skies 2
https://valkyrienskies.org/
GNU Lesser General Public License v3.0
223 stars 97 forks source link

Mixin crash running runClient #904

Open ProGaMEr110521 opened 3 months ago

ProGaMEr110521 commented 3 months ago

This issue occurs when only Valkyrien Skies and addons are installed and no other mods

Minecraft Version

1.18

Mod Loader

Forge

Issue description

If you try to build, everything works without problems. But when I try to runClient it crashes with the error that the preMaybeBackOffFromEdge() method does not exist. gradle runClient crashing with:

[main/FATAL] [mixin/]: Mixin apply failed valkyrienskies-common.mixins.json:feature.entity_collision.MixinPlayer -> net.minecraft.world.entity.player.Player: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException Critical injection failure: @Inject annotation on preMaybeBackOffFromEdge could not find any targets matching 'Lnet/minecraft/world/entity/player/Player;m_5763_(Lnet/minecraft/world/phys/Vec3;Lnet/minecraft/world/entity/MoverType;)Lnet/minecraft/world/phys/Vec3;' in net.minecraft.world.entity.player.Player. Using refmap valkyrienskies-118-common-refmap.json [PREINJECT Applicator Phase -> valkyrienskies-common.mixins.json:feature.entity_collision.MixinPlayer -> Prepare Injections -> -> handler$zbn000$preMaybeBackOffFromEdge(Lnet/minecraft/world/phys/Vec3;Lnet/minecraft/world/entity/MoverType;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfoReturnable;)V -> Parse]

Issue reproduction

Real-Zaruba-Gamemode---Stable.zip

Gradle build and properties file to reproduct the problem

Logs

message (2).txt

ByThePowerOfScience commented 2 months ago

could not find any targets matching 'Lnet/minecraft/world/entity/player/Player;m5763(Lnet/minecraft/world/phys/Vec3;Lnet/minecraft/world/entity/MoverType;)

This means it's checking for the remapped (SRG) name, which Mixin shouldn't be doing in a deobfuscated dev environment. I don't see anything that would force-remap it in the source code, so make sure you included the jar in your buildscript with fg.deobf, and double-check if other mods that use Mixin are breaking in the same fashion if that doesn't work.

This isn't something VS can physically cause on its own as far as I can tell, so make sure Mixin as a whole is working properly for dependencies in your environment.

thetheaplant commented 3 weeks ago

Non VS related issue, seems to be user error.