search

ValkyrienSkies / Valkyrien-Skies-2

Valkyrien Skies 2
https://valkyrienskies.org/
GNU Lesser General Public License v3.0
230 stars 99 forks source link

Game crashes randomly with just VS2 and Distant Horizons installed #913

Open MrBenjaminBowman opened 4 months ago

MrBenjaminBowman commented 4 months ago

Mod Name

Distant Horizons

This issue occurs when only Valkyrien Skies, addons, and the mod I have specified are installed and no other mods

Minecraft Version

1.20.x

Mod Loader

Forge

Issue description

Saw this issue across the discord, whittled down the issue to just Valkyrien Skies 2 (+ Kotlin) and Distant Horizons. Have seen other users get this crash in Fabric version as well.

Issue reproduction

Logs

Crash type 1: latest.log crash-2024-07-21_19.50.06-server.txt Crash type 2: 2024-07-21-7.log crash-2024-07-21_19.41.52-server.txt

dantaeusb commented 3 months ago

Can confirm, but for me, it's not that random. I was running chunk pregen for hours with no issues, and DF generated 128 chunks around player without crashes. For me, it reproduceably crashes when I actively travel around the world, loading new chunks (possibly with DF), but not just passively standing.

MrBenjaminBowman commented 3 months ago

Can confirm, but for me, it's not that random. I was running chunk pregen for hours with no issues, and DF generated 128 chunks around player without crashes. For me, it reproduceably crashes when I actively travel around the world, loading new chunks (possibly with DF), but not just passively standing.

It seems more consistent to make the crash happen while loading new chunks, though I've gotten it to happen without moving as well.

EnragedPotato commented 3 months ago

This has been my experience too. Not sure if it's just luck but I haven't seen either crash happen yet while DH distant generation is either off or only set to pre-existing chunks rather than features, I would need to test it more though to see if that's actually the case though. I have definitely had crash type 1 occur while standing still when DH is set to distant generate features. Chunky seems to perform perfectly fine though, as has been mentioned.

Anecdotally, I originally had crash type 1 occur very rarely on a personal Fabric modpack but it would be days of playing before I would see it happen once. Now that I'm on Forge both crash types seem to happen way more often, usually within 25 minutes of distant generation being set to features, particularly if I move around at the same time.

blockninja124 commented 3 months ago

I’ve seen people on the VS discord say that downgrading distant horizons to 2.1.0-a solved the issue for them, so it’s possible the change was made by DH sometime between 2.1.0-a and 2.1.2

EnragedPotato commented 3 months ago

I’ve seen people on the VS discord say that downgrading distant horizons to 2.1.0-a solved the issue for them, so it’s possible the change was made by DH sometime between 2.1.0-a and 2.1.2

Come to think of it, I don't remember experiencing this while on the DH 2.1.1-a dev build on Fabric either, seemed to start around the time I updated to 2.1.2. Thanks for the tip, I'll have to check that out.

MrBenjaminBowman commented 3 months ago

I’ve seen people on the VS discord say that downgrading distant horizons to 2.1.0-a solved the issue for them, so it’s possible the change was made by DH sometime between 2.1.0-a and 2.1.2

Can confirm that after downgrading to 2.1.0-a I have yet to experience this crash.

blockninja124 commented 3 months ago

Also on the discord @galaxy_28 has said that loading the nether dimension crashes pretty fast. As you can see here

gededo commented 2 months ago

Does anyone know if Distant Horizons 2.2.0 fixes this issue? Will be testing it myself soon.

StewStrong commented 2 months ago

I do have an attempt at a fix, tho this needs testing https://github.com/ValkyrienSkies/Valkyrien-Skies-2/commit/4645958acd8c745791f1d5eec4871f1dd2e128e4