ValkyrienSkies / Valkyrien-Skies-2

Valkyrien Skies 2
https://valkyrienskies.org/
GNU Lesser General Public License v3.0
232 stars 100 forks source link

Having Nostalgic Tweaks installed breaks all sounds on ships. #987

Open hl2jeep opened 1 month ago

hl2jeep commented 1 month ago

This issue occurs when only Valkyrien Skies and addons are installed and no other mods

Minecraft Version

1.20.x

Mod Loader

Forge

Issue description

With the Nostalgic Tweaks mod installed, regardless of whether it's enabled or any of the sound setting are toggled, there will be no sounds on ships what so ever.

Issue reproduction

  1. Install Forge + Valkyrian skies + nostalgic tweaks.
  2. run the game and build a ship
  3. notice that there will be no sound of block placing and breaking, aswell as footsteps.

Logs

N/A, no difference in logs between having nostalgic tweaks installed and not. EDIT: Yes I did double check this, i wasn't able to find any differences between the logs of having it enabled and not, i made a fresh instance to test it out.

hl2jeep commented 1 month ago

I think my previous log was damaged, here's the actual log file, srry Log

xiewuzhiying commented 1 month ago

https://github.com/Adrenix/Nostalgic-Tweaks/blob/1.20.1/common/src/main/java/mod/adrenix/nostalgic/mixin/tweak/sound/position_sound/ClientLevelMixin.java

I suspect it's causing this issue, but I haven't gotten into the game to test it yet.