search

ValkyrienSkies / Valkyrien-Skies

Moving structures powered by a custom multi-threaded physics engine; in Minecraft.
https://valkyrienskies.org/
Apache License 2.0
161 stars 40 forks source link

Valkyrien+MTS Conflicts. #183

Open Reva0182 opened 6 years ago

Reva0182 commented 6 years ago

The mod Minecraft Transportation Simulator has some very serious issues with Valkyrien Warfare. The issue is that when Valkyrien Warfare is installed the MTS vehicles all fall through the world whether they are just placed or been spawned since before VW was installed. The issue has been brought to the dev team of MTS and I am bringing it to your side in the hopes that this issue can be resolved. I am dying to play with both Valkyrien and MTS with my friends! we want to play privately on our own little server and build a town to roleplay in but with MTS vehicles 100% unusable with VW installed that makes it very hard for me to find a good use for Valkyrien in any modpack I want to design that it would fit into. So if you could please maybe get ahold of the MTS dev team and try and work together to fix the issue or something that would be a huge help. Also having your crash and bug section of Discord locked to force GitHub is really irritating because I wont know if this was responded to or even viewed at all outside having to come back here which I never do.

Reva0182 commented 6 years ago

Alright so Minecraft Transportation Simulator's master coder don_bruce is more than willing to work with you on resolving this issue. As far as any further information you may need the minecraft version is 1.12.2 and I have MTS and its 2 vehicle packs, the official pack as well as BlackThorne Vehicle Pack so that should help you. All mods are the most recent versions. If there is any information you need along with this my username on here is how to reach me on discord. I am also in your discord server so I can be reached through there quite easily. Reva#0182 since GutHub does not allow # in a name.

Reva0182 commented 6 years ago

It has been more than a day since this was posted. I am going to close the tab that this is in but the issue can stay open. I will check back tomorrow and every day until I get a response. As far as MTS Master Coder don_bruce is concerned this issue is something he is beyond happy to help resolve, so if you would not mind please either getting ahold of me on discord and I will get you in touch with him or find him on the MTS discord itself, this issue can be resolved with hopefully relative ease. The issue as far as don_bruce knows is your mod injecting physics which is breaking his mod. I am sure he is willing to rewrite some code to help counteract this for his mod or help your mods code be fixed to only affect what your mod actually interacts with seeing as MTS uses spawned entities that can be customized rather than building your own vehicles out of blocks. Your mod is fantastic at adding in good reliable physics for airships and things of that nature but to be unable to use it alongside Sponge as well as MTS that makes your mod not viable for me in any way shape or form. Therefore I am going to have to stop using Valkyrien Warfare until this issue is resolved. This truly hurts me as I would much rather have nice working ships over using Davincis Vessels which makes a giant entity that cannot be moved around on while it is moving.

Reva0182 commented 6 years ago

Still no response? Seem's like this mod is going to die from neglect with their issues. I do not mean this as an insult but I am taking this as an insult due to this being over a month old now and still absolutely no response in any way shape or form.

Sunspot0411 commented 6 years ago

This bug is not of priority, cause there are a lot more serious problems than this one. And I should remained you that this mod is still in beta test, it's not officially released until version 1.

Rubydesic commented 5 years ago

First of all, I'd like to offer a personal apology for this issue not receiving a response in months. This is definitely an oversight from us and I really apologise that you were ignored for so long. We are working on changing a lot of new systems before we tackle incompatibility issues, but know that your voice is heard loud and clear. An improved API is in the works to allow easier compatibility with other mods such as this.

Again, really sorry that you were forced to wait! You can reach me on Discord anytime, just mention me. Your detailed description of the incompatibility is extremely valuable when debugging and trying to fix things.

I appreciate every single report we get, so don't stop sending them. That said, we have a lot of work set out for us in release v1 of Valkyrien Warfare and therefore fixing game-breaking bugs and making the mod's experience more stable, fun, and consistent is our number one priority.

What this means for you: we might not be fixing this bug that soon. However, keep reporting these issues to us, it's really helpful and allows us to fix them when we get a chance.

With <3, Valkyrien Warfare Team

DonBruce64 commented 4 years ago

Want to mention that this appears to be fixed as of ValkyrienSkies-1.12.2-1.0-alpha-1. At least from the reports of my community vehicles no longer fall into the dark abyss, and now thoughts of landing MTS planes on Valkyrien airships are filling people's heads. Should be fun!

DonBruce64 commented 4 years ago

Back again. Turns out this issue was fixed in ValkyrienSkies-1.12.2-1.0-alpha-1 but it re-appears in Valkyrien Skies 1.12.2-1.0.0 and onward.

Rubydesic commented 4 years ago

TODO: Bisect VS between 1.0-alpha-1 and 1.0.0 to find out which commit introduced the issue

Fureniku commented 4 years ago

Following as I reported the issue to DonBruce - I'm happy to help test any potential fixes, so feel free to ping me on Discord if you need any tests (@Fureniku#4839)

gatoborrachon commented 3 years ago

i would be interested in test any possible solution to this issue too, since there's an ore mandatory to build ValkyrienSkies ships i don't feel so good pregenerating terrain without this mod, also any kind of implementation of boats would be nice too

gatoborrachon commented 3 years ago

Update: now vehicles are practically functional, but there are some critical visual bugs and when you try to get out of a vehicle it appears that you die from fall damage (it even hurt you in creative)

Versions: MTS: Immersive+Vehicles-1.12.2-19.11.0 VS: valkyrien-skies-1.12.2-1.1.0

Videos: https://streamable.com/9nesys (Custom modpack) https://streamable.com/1m7vpk (MTS and VS only)

Jimmy805 commented 3 years ago

Now the feature of water float is released. If the combat between Valkyrien and MTS is solved, I think I can make aircraft carriers with F-14 from Gyro Hero's Helicopter Pack (Though it isn't coming out now)