search

ValkyrienSkies / Valkyrien-Skies

Moving structures powered by a custom multi-threaded physics engine; in Minecraft.
https://valkyrienskies.org/
Apache License 2.0
161 stars 39 forks source link

[Issue] OpenComputers Incompatibility #489

Open gatoborrachon opened 3 years ago

gatoborrachon commented 3 years ago

What went wrong: When you start a new world with OpenComputers and ValkyrienSkies, you will see a warning about a Class Transformer from OpenComputers, 2021-04-03_15 23 35

and when you try to build a PC in a ValkyrienSkies ship, the PC will not be able to start with the following Soft Crash inside the Log: https://pastebin.com/SFrU2nq2 2021-04-03_15 29 12

Versions: OpenComputers-MC1.12.2-1.7.5.192 valkyrien-skies-1.12.2-1.1.6 valkyrien-skies-control-1.12.2-1.1.1 valkyrien-skies-world-1.12.2-1.0.0

Related Issue: https://github.com/MightyPirates/OpenComputers/issues/3418

deltanedas commented 3 years ago

1.12 is dead

gatoborrachon commented 3 years ago

well, that's a shame, but lets see if Triode maybe can work only in that old OpenComputers Module to at least let Computers run inside a Ship

asiekierka commented 1 year ago

The issue is that OpenComputers sends packets off the main thread, which requires a call to player.getDistanceSq(), which in Valkyrien Skies is enforced to be on the main thread.