search

ValkyrjaProject / Valkyrja.discord

[C# - netcore] Community Management bot for Discord
https://valkyrja.app
MIT License
35 stars 13 forks source link

Fixed mods / admins / server owners being able to ban themselves. #5

Closed AraHaan closed 7 years ago

AraHaan commented 7 years ago

This command does not fail with You cannot ban yourself. So as such now it does. This fixes mods and admins who would and could try to ban themselves with boredom realizing that it does not fail on them.

RheaAyase commented 7 years ago

Well this will take a while. Github diff is completely fucked up and I can't read any of that :D

AraHaan commented 7 years ago

ah, I also realized the file was using a lot of tabs. It would be nice if botwinder's files used 4 spaces instead of tabs so it is easier to see.

AraHaan commented 7 years ago

Also should I suggest an CI to test if build works when someone opens an PR or when you or anyone commits to this repo?

Also cant you see it with this?

RheaAyase commented 7 years ago

I don't have time for that.. Also working build is irrelevant, I need the code to be logically correct, not just compile-able.

AraHaan commented 7 years ago

alright

RheaAyase commented 7 years ago

Not to be mean but this code wouldn't even compile...