ValleyAudio / ValleyRackFree

Modules for VCV Rack
Other
176 stars 24 forks source link

Dexter: Logic Pro crashes when fetching a control name #100

Open bl-nero opened 1 month ago

bl-nero commented 1 month ago

Steps to reproduce:

  1. Create an empty MIDI track in Logic Pro.
  2. Add VCV 2 Stereo instrument.
  3. Add MIDI Map (MIDI Map, not MIDI -> CV) and Dexter modules.
  4. Map any CC to any Dexter knob (I tried with CC01 and CC07, Voice A Octave, Op 2 Level).
  5. Click "Show/hide automation" in Logic Pro. The automation selector drop-down should now be visible.
  6. Click the automation selector drop-down.

Boom! Logic Pro crashes. Here's the stack trace:

Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   CoreFoundation                      0x7ff81afcb444 CF_IS_OBJC + 12
1   CoreFoundation                      0x7ff81ae8cf5d CFStringGetCString + 65
2   MAAudioEngine                          0x109a871a4 MAAEAudioUnit::AU2PlugIn::GetControlName(short, unsigned long, char*) + 212
3   Logic Pro X                            0x1055b7e03 0x103fd0000 + 22969859
4   Logic Pro X                            0x1055b92be 0x103fd0000 + 22975166
5   Logic Pro X                            0x104fcc582 0x103fd0000 + 16762242
6   Logic Pro X                            0x1046b9305 0x103fd0000 + 7246597
7   Logic Pro X                            0x1046ba28d 0x103fd0000 + 7250573
8   Logic Pro X                            0x1046b6ea6 0x103fd0000 + 7237286
9   Logic Pro X                            0x1046bbcab 0x103fd0000 + 7257259
10  Logic Pro X                            0x1046bcc27 0x103fd0000 + 7261223
11  Logic Pro X                            0x1046bccfb 0x103fd0000 + 7261435
12  Logic Pro X                            0x10562fa6d 0x103fd0000 + 23460461
13  Logic Pro X                            0x104977e49 0x103fd0000 + 10124873
14  Logic Pro X                            0x104dc6e12 0x103fd0000 + 14642706
15  Logic Pro X                            0x10497e565 0x103fd0000 + 10151269
16  Logic Pro X                            0x105381d6e 0x103fd0000 + 20651374
17  AppKit                              0x7ff81e74e2f3 -[NSWindow(NSEventRouting) _handleMouseDownEvent:isDelayedEvent:] + 4582
18  AppKit                              0x7ff81e6c70ce -[NSWindow(NSEventRouting) _reallySendEvent:isDelayedEvent:] + 404
19  AppKit                              0x7ff81e6c6d1f -[NSWindow(NSEventRouting) sendEvent:] + 345
20  Logic Pro X                            0x10442ff58 0x103fd0000 + 4587352
21  AppKit                              0x7ff81ee762b6 -[NSApplication(NSEventRouting) sendEvent:] + 346
22  Logic Pro X                            0x105763834 0x103fd0000 + 24721460
23  Logic Pro X                            0x105763322 0x103fd0000 + 24720162
24  Logic Pro X                            0x10575d5ab 0x103fd0000 + 24696235
25  Logic Pro X                            0x10576386e 0x103fd0000 + 24721518
26  Logic Pro X                            0x105763322 0x103fd0000 + 24720162
27  AppKit                              0x7ff81ea315c2 -[NSApplication _handleEvent:] + 65
28  AppKit                              0x7ff81e55902a -[NSApplication run] + 640
29  AppKit                              0x7ff81e52cff1 NSApplicationMain + 816
30  Logic Pro X                            0x104a9dfc3 0x103fd0000 + 11329475
31  dyld                                0x7ff81aa99366 start + 1942

Notes:

  1. I tried to reproduce the same thing with Valley Plateau, and it didn't break.
  2. A similar crash appears also when I try to use the "cycle through" button in the region automation view.
  3. The issue persists, even if you get rid of the MIDI mapping component, essentially poisoning the track forever.

Configuration: CPU: Intel Core i7 MacOS Sonoma 14.4.1 VCV Rack Pro 2.5.2 x64 Valley plugin 2.4.5

bl-nero commented 1 month ago

Update: it turns out, it doesn't even require having the CC mapped through MIDI Map. It's enough to have Dexter in the patch at all. VCV Rack seems to report all of the knob names as parameters to the DAW.

bl-nero commented 1 month ago

Another update: the problem suddenly stopped appearing. It may have had something to do with a botched Logic Pro v11 upgrade.