search

ValleyAudio / ValleyRackFree

Modules for VCV Rack
Other
176 stars 26 forks source link

Add Cardinal specific changes #70

Closed falkTX closed 2 years ago

falkTX commented 2 years ago

Hi there.

This PR adds the necessary changes to make the Terrorform osdialog usage work within Cardinal. Since osdialog calls are blocking, Cardinal does not use it (it is in my opinion very bad practice for plugins to block the main event loop).

Changes to the code are made in a way that compatibility with regular Rack remains intact. I tried to change things as little as possible, the part about onLoadWAVCallback was an odd one due to it expecting a blocking operation. Hopefully all still makes sense in the end. Let me know if you have any questions.

falkTX commented 2 years ago

Just added it now, force-pushed so it remains 1 single commit.

Sorry didn't realize this little change was needed, it has been a long time since I built the official Rack. :sweat_smile: