search

ValleyAudio / ValleyRackFree

Modules for VCV Rack
Other
176 stars 26 forks source link

Dexter V/oct input is 0.1 at max but should be 1.0 #95

Closed Petervos2018 closed 1 year ago

Petervos2018 commented 1 year ago

Hi Dale,

Edit 3rd november 2023 : using the V/Oct A and B work as expected, but I still can’t change the whole range of Algos via CV. (and it’s not backward compatible with V 1)

I am talking about the CV inputs, they are all 1/10 of the old (V1) range, they should be going to 1 instead of 0.1 max.

afbeelding

When I play an octave it only gives me 1/10 of a scale, when I multiply the cv by ten it works as expected.

See also

https://community.vcvrack.com/t/looking-for-valley-dexter-presets/20847/10?u=yeager

afbeelding

All these go from 0 to +-0.1 but should go from 0 to +-1.0

And the assignable mods 1 to 4 go from 0 to +-1.0 but the range is only +-0.5 at max (but this was also the case in V1 so better to not change this for backwards-compatibility )

In V1 you had

https://github.com/ValleyAudio/ValleyRackFree/blob/6b0f6e39b2a544b11eade58bab93a588275ee36d/src/Dexter/Dexter.cpp#L67

In V2 you have

https://github.com/ValleyAudio/ValleyRackFree/blob/9a43da65e74c08a7b113135498329e083fd0c16c/src/Dexter/Dexter.cpp#L67

Somewhere you went from 1.0 to 0.1

Greetings Peter

Also the ago parameter is wrong it only gives me 3 of the available 23 alos

afbeelding

If you feel this is a nonsense post please close it.

ValleyAudio commented 1 year ago

Thanks for spotting that! Fixed in upcoming version 2.4.5