ValleyBell / MidiConverters

various tools that convert game data into MIDI files
GNU General Public License v2.0
100 stars 14 forks source link

Pitch bend doesn't work properly in IT2MID #6

Closed turboboy215 closed 4 years ago

turboboy215 commented 4 years ago

I have recently been using your IT2MID program, and I must say it's been working well. The MIDI files it outputs are "more optimized" than those generated from OpenMPT's export function. However, one thing is incorrect that even OpenMPT sort of gets right: the pitch bend function when converting Exx and Fxx commands, which some of my songs that I made have a lot of. It seems that it's mapped to the "modulation" command rather than pitch bend when I open it in a MIDI editor, and doesn't seem to change pitch very much at all. All of your other MIDI converters don't have this issue. What is happening here? Is it a bug or is there a way to get these pitch slides right?

ValleyBell commented 4 years ago

I'm afraid that the Pitch Slide commands are indeed mapped to General Purpose 3/4 + Modulation.

it2mid just converts all events very literally. It doesn't have an actual per-tick channel processor, which it would need in order to convert pitch slide commands into actual pitch bends.

tl;dr it's not a bug, but a limitation of the tool.

turboboy215 commented 4 years ago

How would I accurately convert my Its to MIDI then with proper pitch bend? Would you have to re-write the tool? Do I have to use OpenMPT’s feature instead?

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: ValleyBellmailto:notifications@github.com Sent: Wednesday, November 27, 2019 12:56 PM To: ValleyBell/MidiConvertersmailto:MidiConverters@noreply.github.com Cc: turboboy215mailto:superwill@live.com; Authormailto:author@noreply.github.com Subject: Re: [ValleyBell/MidiConverters] Pitch bend doesn't work properly in IT2MID (#6)

I'm afraid that the Pitch Slide commands are indeed mapped to General Purpose 3/4 + Modulation.

it2mid just converts all events very literally. It doesn't have an actual per-tick channel processor, which it would need in order to convert pitch slide commands into actual pitch bends.

tl;dr it's not a bug, but a limitation of the tool.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FValleyBell%2FMidiConverters%2Fissues%2F6%3Femail_source%3Dnotifications%26email_token%3DADY3TZPKE5TL23ACQ6X7MCDQV3NGVA5CNFSM4JR7TQZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFKXF6Q%23issuecomment-559248122&data=02%7C01%7C%7Ce38886e4c6a5480f916408d7737c3b88%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637104849715272989&sdata=mWIO8WqPB1LcrWPNGHkpqpyGiFe1dm3t0KLz9HtfjSM%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADY3TZPRXICDZ5ROOGCW773QV3NGVANCNFSM4JR7TQZQ&data=02%7C01%7C%7Ce38886e4c6a5480f916408d7737c3b88%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637104849715283012&sdata=wmzb70Xv8GI3BAlvc8y%2BCQDwAxGzQp9gzPs9FJsqBtI%3D&reserved=0.

ValleyBell commented 4 years ago

Yes, you will have to use OpenMPT's exporter or maybe LifeAmp. Actual pitch bend support would require me to rewrite major parts of the tool.

ValleyBell commented 4 years ago

I'm closing this with won't fix as right now I don't intend to rewrite it2mid.

Pull requests are welcome though.