YMF278: Restart sample position when wave changes during release.

ValleyBell / libvgm

A more modular rewrite of most components from VGMPlay. will include sub-libraries for audio output, sound emulation and VGM playback

irc://irc.digibase.ca/#vgmrips

136 stars 33 forks source link

YMF278: Restart sample position when wave changes during release. #100

Closed grauw closed 2 years ago

grauw commented 2 years ago

I verified on real OPL4 that changing wave during key on indeed retriggers the EG, and doing so during key off does not. The EG state is unaffected other than the new wave table parameters being applied to it. The sample position does get reset though, so it plays from the beginning.

See https://github.com/openMSX/openMSX/pull/1420 for test case.

ValleyBell commented 2 years ago

Thanks!