search

ValleyBell / libvgm

A more modular rewrite of most components from VGMPlay. will include sub-libraries for audio output, sound emulation and VGM playback
irc://irc.digibase.ca/#vgmrips
136 stars 33 forks source link

audemutest: Update broken Resampler mode #122

Closed Simon-L closed 1 month ago

Simon-L commented 1 month ago

Following up on our chat on IRC about audemutest. Thanks for the help!

audemutest hadn't been updated with a working resampler mode since the breaking change in 77c34eb8cc96eaf44f8f4125a89356f6d5ffc76a that made 0xFF invalid. Updated and working value for mode taken from here: https://github.com/ValleyBell/libvgm/blob/master/player/vgmplayer.cpp#L1599

This test worked on an out-of-date fork of libvgm, so I tested every commit since then until it broke again.

Commit:

ValleyBell commented 1 month ago

Ah, so that was the issue. Thanks a lot!

kode54 commented 1 month ago

By the way, for future reference, you can use git bisect to more quickly locate broken commits. You start it, flag start/end commits as good/bad, then it starts in the middle and bisects halfway, changing direction depending on how you vote the current commit. So glad I learned about this feature.