search

Valloric / MatchTagAlways

A Vim plugin that always highlights the enclosing html/xml tags
http://valloric.github.com/MatchTagAlways/
GNU General Public License v3.0
540 stars 24 forks source link

Remove redundant check for python support #17

Closed sharat87 closed 9 years ago

sharat87 commented 9 years ago

The check for python in line 18 is incomplete as it checks only for python2 whereas the plugin clearly supports python3. For those of us who have python3 support but not python2, your plugin doesn't load. Besides, python support is being checked for, with a helpful error message in the next code block.

Valloric commented 9 years ago

Removing that check would mean explicitly supporting python3. I've never tested MTA in such a configuration, so saying "he plugin clearly supports python3" could be complete accident.

Do we know for a fact that everything works in python3?

Valloric commented 9 years ago

Actually, I'm wrong. There was a recent pull request that added python3 support. So that's covered.

What we need is a way to check for either python2 or python3 support. Since the user can have Vim configured without any Python support at all, removing the checks entirely is a bad idea.

sharat87 commented 9 years ago

I'm not sure I follow you. I'm not removing the checks for python entirely. Only the redundant check. I'm using it on python3 now and it works a charm. No problems so far.

Valloric commented 9 years ago

You're right, I read it wrong! :)