Assorted improvements to Validation service

ValueChart / WebValueCharts

A web implementation of ValueCharts.

2 stars 3 forks source link

Assorted improvements to Validation service #172

Open MalakronikMausi opened 7 years ago

MalakronikMausi commented 7 years ago

Have validation perform "clean up" by removing entities that should not be there
Make sure score function elements (default and user) are in the same order as the objective domain elements
Decouple validation logic from error message creation

MalakronikMausi commented 7 years ago

Marked as bug because of the second bullet. UpdateValueChartService will take care of any order inconsistencies introduced programatically, but it will not pick them up if they are in an imported chart. Although we wouldn't expect users to manually edit the XML, this and similar issues are important to address if ValueCharts is going to consume XML docs generated by other programs.

MalakronikMausi commented 7 years ago

Clean up should not be done by the Validation service itself. It should call methods in UpdateValueChartService.