search

ValvePython / dota2

🐸 Python package for interacting with Dota 2 Game Coordinator
http://dota2.readthedocs.io
201 stars 32 forks source link

get_practice_lobby_list() incomplete results #32

Closed ifSomeday closed 7 years ago

ifSomeday commented 7 years ago

Running dota.get_practice_lobby_list() returns a list of 5 lobbies.

There are more than 5 lobbies, and checking the same request using NetHook2 shows that there is indeed more than 5 lobbies returned. The length of the actual result should be ~100 lobbies

rossengeorgiev commented 7 years ago

Looks like the method doesn't have kwargs for some of the message fields. It's probably not getting a the full list. Since you've nethooked it already, can provide the contents of EMsgGCPracticeLobbyList ?

rossengeorgiev commented 7 years ago

The above change adds get_lobby_list method, which will get you regular lobbies. Practice lobby list gets you only customs game lobbies.

Update to the latest version to which includes the changes.