search

ValvePython / dota2

🐸 Python package for interacting with Dota 2 Game Coordinator
http://dota2.readthedocs.io
201 stars 32 forks source link

Recursives calls on chat feature. #34

Closed Philaeux closed 6 years ago

Philaeux commented 6 years ago

Some calls on self.lobby and self.party create a recursive loop in dota2.features.chat.ChannelManager. They must be replaced by self._dota.party and self._dota.lobby.

Check this function for example: https://github.com/ValvePython/dota2/blob/38682efee6287faadae3b736bbe84a98332d20be/dota2/features/chat.py#L198-L208

rossengeorgiev commented 6 years ago

Nice find. Do you want to submit a PR for it?

Philaeux commented 6 years ago

I will make one today.