Open luckydonald opened 2 years ago
That's a good point.
SteamAuthenticatorError
should really inherit from steam.exceptions.SteamError
. And then any places where it sets the eresult
should be passed as parameter. This looks like a straightforward change
I can see if I have time to do a PR
Made one.
So current situation is that stuff like
SteamAuthenticator(…).add()
can causeSteamAuthenticatorError
.For example,
Now that's a pretty easy to catch that error, telling the user to first have it log off the old instance, hence duplicate. Just, we can't really distinguish those errors unless we do some ugly string stuff on that returned string.
This is obviously super prone to issues due to changes there, it would be way better to just include those fields in the exception.