read_string() throws UnicodeDecodeError exception

ValvePython / vdf

📜 Package for working with Valve's text and binary KeyValue format

https://pypi.org/project/vdf/

MIT License

165 stars 30 forks source link

read_string() throws UnicodeDecodeError exception #15

Closed pznmc closed 5 years ago

pznmc commented 5 years ago

Used by ValvePython/steam. Affected package id: 82985

https://sentry.io/share/issue/27c635a7e4c34a8f867df27c644212e7/

rossengeorgiev commented 5 years ago

Cannot replicate.

In [10]: client.get_product_info([], [82985])
Out[10]:
{'apps': {},
 'packages': {82985: {'appids': {'0': 261450},
   'appitems': {},
   'billingtype': 10,
   'depotids': {'0': 261451,
    '1': 261452,
    '2': 261453,
    '3': 261454,
    '4': 261455,
    '5': 261456,
    '6': 261457},
   'extended': {'\xe2\x80\x9ccanbegrantedfromexternal\xe2\x80\x9d': 1},
   'licensetype': 1,
   'packageid': 82985,
   'status': 0}}}

pznmc commented 5 years ago

Which python version are you using?

I can make it to work only on python 2.7, but any 3.4+ throws an exception.

rossengeorgiev commented 5 years ago

Pushed a new version of the package with a fix