ValveSoftware / Dota-2

Tracker for issues specific to Linux and Mac in the Reborn client. If you have a general issue or non-system-specific feature request please go to dev.dota2.com
469 stars 38 forks source link

Linux: Duplicate Desktop Notifications #1064

Open RogerDodger opened 7 years ago

RogerDodger commented 7 years ago

When a matchmaking match is found or a lobby game starts, two desktop notifications are emitted:

Matchmaking Status Your game is ready

dota2 Dota 2 is ready

Expected behaviour: Only one notification is emitted.


When the game is unpaused, no desktop notification is emitted.

Expected behaviour: A notification is emitted when the unpause countdown begins.

gdrewb-valve commented 7 years ago

Can you post the full system info from Steam? Also have you customized your system notification settings (not Dota) in any way?

ramma commented 7 years ago

Is there an easy way to test the desktop notifications without having to play a game or decline a game?

I haven't been getting them for a while now. Probably since upgrading to Ubuntu 16.04.1 when the dist upgrade became available. Sys info

gdrewb-valve commented 7 years ago

I'm not aware of one, unfortunately.

gdrewb-valve commented 7 years ago

I don't see a second notification, that might be something your DE is generating.

The feature request for more notifications should be posted a dev.dota2.com.

RogerDodger commented 7 years ago

Full system info. Running GNOME3 Window Manager (gnome-shell), Desktop Manager (gdm), and Desktop Environment. I haven't customised my notification settings at all.

I don't think it should be my DE doing something irregular since the start of the hero picking phase only emits the following notification:

Matchmaking Status The hero picking phase has begun

Dota 2 must be doing something different when emitting the "Your game is ready" notification for it to emit two.

I also note that the notifications titled "Matchmaking Status" when clicked only dismiss the notification, whereas the "Dota 2 is ready" one will cause the Dota 2 window to focus.

gdrewb-valve commented 7 years ago

The notification that Dota gives always have the title "Matchmaking Status", that's the only string it uses. It also only has one code path for notifications so all notifications function identically. It's a mystery as to why you see two, we'll have to see if other people hit it and we can figure out the common factor.

gdrewb-valve commented 7 years ago

If you use notify-send from a terminal window does it just send one notification?

RogerDodger commented 7 years ago

Yes

BrendanBall commented 7 years ago

@gdrewb-valve apparently dota 2 does give a desktop notification on windows when unpausing. However this doesn't happen on Linux. The game is ready notification works fine and gets sent through libnotify so I'm pretty sure this is a bug. Can we open a separate issue for the unpause notification as this issue seems to be for the duplicate notification (which I haven't experienced.)?

gdrewb-valve commented 7 years ago

@BrendanBall you are welcome to open issues for anything you think isn't covered.

gdrewb-valve commented 7 years ago

The missing notifications have been addressed, correct? The only issue here now is duplicate notifications?

Cabanur commented 7 years ago

On KDE, I still don't get notifications when finding game.

gdrewb-valve commented 7 years ago

@Cabanur does notify-send work on your system?

Cabanur commented 7 years ago

@gdrewb-valve Other apps (like spotify and firefox) were correctly showing system notifications so I just assumed everything was fine in my system. No, notify-send doesn't work on my system, but kdialog --passivepopup does.

Looking into this, libnotify4 is installed, but libnotify-bin is not. Installing it right now, will report back next time i play Dota.

BrendanBall commented 7 years ago

@gdrewb-valve I'm pretty the issue I created regarding missing notifications has been addressed and is closed. All notifications have been working perfectly for me for a while now. I'm running Arch Linux so as long as libnotify and any notification server is installed and working properly I don't see why it wouldn't work on a distro like ubuntu (which has it installed by default). @Cabanur KDE by notify-send not working do you mean it's not installed or it is installed and using it doesn't create notifications? @gdrewb-valve do you actually need notify-send installed or is that just for testing purposes? ie. does Dota 2 use notify-send or plug in directly to the DBus?

gdrewb-valve commented 7 years ago

notify-send is used so it must be present and functioning.

Cabanur commented 7 years ago

After installing libnotify-bin, which provides notify-send, it works.

gdrewb-valve commented 7 years ago

Thanks. RogerDodger hasn't responded but I'm going to edit this to only mention the duplicates.