ValveSoftware / Dota-2

Tracker for issues specific to Linux and Mac in the Reborn client. If you have a general issue or non-system-specific feature request please go to dev.dota2.com
472 stars 38 forks source link

Exclusive full screen does not work properly after Dueling fate updates #1333

Closed bojunwu closed 7 years ago

bojunwu commented 7 years ago

I'm using the 2017 15-inch Macbook Pro with Radeon 560 graphics card + i7-7820HQ and 16GB of RAM. For stability issue I'm using the lastest Mac OS Sierra, no high sierra yet. This is what I see when I launch the game today after the updates. Desktop-friendly full screen works but the resolution is so low on a retina display.

screen shot 2017-10-31 at 6 05 41 pm
bojunwu commented 7 years ago

This is a FULL screen screenshot.

webquali commented 7 years ago

I have the same macbook and the same problem. I reinstall steam and dota but problem not leave. And also I don't have real full screen. If I move mouse to left top corner I have call Dshboard

2017-11-01 18 33 46
macbook15 commented 7 years ago

the same MacBook the same problem, that's too upset

macbook15 commented 7 years ago

the screen resolution is 2880*1800,but only 1440 resolutions can be used properly, if use 2880 with a -fullscreen code, the mouse can't click the right side of the screen, it's disaster, the game has been ruined by the new patch.

bojunwu commented 7 years ago

As of Nov/2 the bug has not yet been fixed. Only part of the game is displayed on the screen.

screen shot 2017-11-02 at 1 28 04 pm
webquali commented 7 years ago

Hey Valve any updates?

Oxidian2005 commented 7 years ago

+1

Mac pro here

10.12.5

3,7 GHz Quad-Core Intel Xeon E5 12GB 1866 MHz DDR3 AMD Fire Pro D500 3072 MB

jeffreythen commented 7 years ago

I have the same problem here. iMac 4k img_0016 Please help!!!

natbro commented 7 years ago

@Oxidian2005 - what type of monitor are you using on your Mac Pro? we haven't yet been able to reproduce this on a variety of different machines but are trying to do so asap.

webquali commented 7 years ago

I have the same @jeffreythen problem on my macbook pro 15 2017

Oxidian2005 commented 7 years ago

@natbro I use one 27’ Mac monitor. The thing is that even in exclusive full screen it is windowed and mac hot corners and dashboard still in use. Don’t think it has to do with actual resolution of size of the screen.

bojunwu commented 7 years ago

I have two 15-inch Macbook Pros. Both machines have discrete GPU. I only have this issue on the one with Mac OS sierra 10.12.6. The other one has high sierra 10.13.1 and it works just fine. But there is another issue with high sierra(GPU performance drop significantly after sleep) so I want to keep one of my laptop at sierra for now.

webquali commented 7 years ago

I have Hight Sierra and have really low fps 13

bojunwu commented 7 years ago

@webquali restart the machine solves the low fps issue for me. But it will come back everytime I put it in sleep mode. Guess it's an issue with high sierra.

webquali commented 7 years ago

@bojunwu the same problem

Oxidian2005 commented 7 years ago

@bojunwu I had Sierra and updated to high sierra to see if it solved the problem. But fps still messed up and there isn’t exclusive full screen.

danginsburg commented 7 years ago

We are still having trouble getting a repro for this here. For those having the problem, can you please post:

Right now we don't have a repro. We'll need to get one to figure it out.

bojunwu commented 7 years ago

@danginsburg Thanks for the reply. img_0294

My desktop resolution is 2880x1800 Video settings are shown in the pic, in case the picture is not clear enough, the settings are: User Advanced Settings, Aspect Ratio 16:10, size 2048x1280(I tried to change this but it doesn't solve the problem),Display Mode Exclusive Fullscreen. Effects are most on and qualities are all high. Rendering quality is 100%.

System info:

Computer Information: Manufacturer: Apple Model: MacBookPro14,3 Form Factor: Laptop No Touch Input Detected

Processor Information: CPU Vendor: GenuineIntel CPU Brand: Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz CPU Family: 0x6 CPU Model: 0x9e CPU Stepping: 0x9 CPU Type: 0x0 Speed: 2900 Mhz 8 logical processors 4 physical processors HyperThreading: Supported FCMOV: Supported SSE2: Supported SSE3: Supported SSSE3: Supported SSE4a: Unsupported SSE41: Supported SSE42: Supported AES: Supported AVX: Supported CMPXCHG16B: Supported LAHF/SAHF: Supported PrefetchW: Unsupported

Operating System Version: MacOS 10.12.6 (64 bit)

Video Card: Driver: Radeon Pro 560 Driver Version: 1.2 Driver Date: 0 0 0 OpenGL Version: 2.1 Desktop Color Depth: 32 bits per pixel Monitor Refresh Rate: 0 Hz VendorID: 0x1002 DeviceID: 0x67ef Revision: 0xc0 Number of Monitors: 1 Number of Logical Video Cards: 2 Primary Display Resolution: 1440 x 900 Desktop Resolution: 1440 x 900 Primary Display Size: 13.03" x 8.11" (15.31" diag) 33.1cm x 20.6cm (38.9cm diag) Primary VRAM: 0 MB

Memory: RAM: 16384 Mb

Miscellaneous: UI Language: English Media Type: DVD Total Hard Disk Space Available: 476182 Mb Largest Free Hard Disk Block: 224008 Mb VR Headset: None detected

ericliu123 commented 7 years ago

Same issue please fix valve!!!!

danginsburg commented 7 years ago

Thanks, I was able to get this repro'd. It appears to be a regression in SDL which I am investigating. As a temporary workaround, you could replace ~/Application Support/Steam/steamapps/common/dota 2 beta/game/bin/osx64/libSDL2-2.0.0.dylib with the attached version.

We'll work on getting a real fix though.

libSDL2-2.0.0.dylib.tar.gz

bojunwu commented 7 years ago

@danginsburg Thank you. It's working. Will replacing this file affect future update of this game ?

danginsburg commented 7 years ago

@bojunwu If you Verify Game Cache it will replace it with the original version. It also will get replaced on a future update once we fix it. Hopefully we'll have a proper fix soon, I will update the bug when we do.

bojunwu commented 7 years ago

Thanks for the help. It works perfectly for me now.

danginsburg commented 7 years ago

The specific SDL commit that is causing the problem is this one:

http://hg.libsdl.org/SDL/rev/1e26564c7288

The problem is that after that change, CGDisplaySetDisplayMode fails in Cocoa_SetDisplayMode with kCGErrorFailure. The following is also output:

Nov 8 11:29:28 dota2[62909] : displaySetMode: unable to find mode dict in array

I'm working with SDL devs to try to find a fix. It is using an undocumented API (kCGDisplayShowDuplicateLowResolutionModes) to make it so CGDisplayCopyAllDisplayModes returns scaled modes, but then downsteam of that the CGDisplaySetDisplayMode seems to fail. It appears to be isolated to AMD, although I'm not sure why.

danginsburg commented 7 years ago

SDL bug filed: https://bugzilla.libsdl.org/show_bug.cgi?id=3949

danginsburg commented 7 years ago

I've put in a fix for this, should be in the next Dota 2 Update.

danginsburg commented 7 years ago

The update has shipped. Should be fixed now.

ericliu123 commented 7 years ago

Appreciate the fast response! Thanks a lot.