[Mac] Pressing and holding ALT/⌘-key doesn't show attack range/viewfinder etc.

hipunk commented 6 years ago

Hi,

Your system information

System information from steam (Steam -> Help -> System Information) in a gist: https://gist.github.com/hipunk/e624855b1fefd8ba74e24822ad24b869
Have you checked for system updates?: [Yes/No] Yes
Are you using the latest stable video driver available for your system? [Yes/No] Yes
Have you verified the game files?: [Yes/No] Yes
Have you reinstalled the game?: [Yes/No] Yes

Please describe your issue in as much detail as possible:

Describe what you expected should happen and what did happen. Please link any large pastes as a Github Gist. Expectation: Pressing and holding the ALT/⌘-key should show the attack range/viewfinders/creepspawn areas/tower attack range. This works in Linux and also did in OS X at the end of 2017. What really happens: It doesn't show up. ALT/⌘-key does get recognized because clicking sends a ping. Disabling it doesn't help. Reenabling doesn't help. Putting the 'Alt Modifier' shortcut on another key doesn't help.

Steps for reproducing this issue:

Launch game.
Enter match.
Position next to a tower.
Press and hold 'Alt Modifier' (⌘ is the default)

I have waited about a month to file this bug as I thought you might fix it, but it didn't get fixed? It's kind of an unfair advantage for Linux/Windows users at this point. I'm not complaining - I'm just pointing it out.

Greetz and thanks,

hipunk

danginsburg commented 6 years ago

We've been unable to repro this on several Macs. For me, holding ALT does the same thing on macOS as it does on Windows/Linux. When I hold Alt/Option on my Macbook Pro (Mid 2012) I see this:

20180409084545_1

Which does what I would expect based on the options (highlights hero, shows neutral spawn boxes, and tower attack range):

20180409084703_1

hipunk commented 6 years ago

Hmm, that is very odd. I would suspect lacking support on my system if I wouldn't know that it once worked. Another thing that kind of shows that it cannot really be something like lack of OpenGL support or similar, is that the range is being shown when e.g. the tower is being clicked like it was before this setting existed, like so: clicking the tower

Another oddity I noticed, is that the hero is being highlighted when the alt key is being pushed down like so: command pushed down (I opened the keyboard viewer for better reference) (See? No attack range)

and then lifted up, like so: command key pressed once and lifted

the arrow above the hero does not disappear. It only disappears when I push down any other key, e.g. option modifier but also others like a - z. Here is the same part of my settings:

settings

Here another one to reassure command key is the alt-key modifier: left command as alt modifier

hipunk commented 6 years ago

I found it! It is this setting:

screen shot 2018-04-09 at 20 30 04

I am using that switched layout since way over a decade, so changing this is absolutely impossible for me 😅 Keys and wizards, wizards and keys...

Can we get the old behaviour back where Dota 2 respected this setting? I know for a fact, that it worked in the past. Of course I've used the range finder in the past (who wouldn't? 🤣) and all my keyboards have had this setting set up since the mac version of Dota 2 exists (and before that)...

I cannot really tell which exact patch broke it, because I was using Ubuntu the last 4 months to enjoy vulkan, amongst other things, but it worked before the renderer setting existed, that is for sure.

Greetz,

hipunk

gdrewb-valve commented 6 years ago

The keyboard system settings are handled underneath Dota, it's not aware of any of those settings. It's possible that something in SDL changed how it interprets keys, assigning to the SDL dev.

hipunk commented 6 years ago

I noticed you ship a new version of SDL in the latest steam beta, sadly it brings no change to this particular issue here.