search

ValveSoftware / Dota-2

Tracker for issues specific to Linux and Mac in the Reborn client. If you have a general issue or non-system-specific feature request please go to dev.dota2.com
470 stars 38 forks source link

[Unplayable] macOS Exclusive Fullscreen Not Working after Summer Client Update #2467

Open JetRunner opened 1 year ago

JetRunner commented 1 year ago

See #2432 and https://github.com/ValveSoftware/Dota2-Gameplay/issues/11241

This problem persists (confirmed on 9/7/2023)

JetRunner commented 1 year ago

Another report is here: https://github.com/ValveSoftware/Dota2-Gameplay/issues/11565

JetRunner commented 1 year ago

If anyone actually plays the game (instead of simply porting Vulkan API to Mac/Linux) can find it out immediately after you tweak the code. It'll be a one-line fix and I guess it'll just take forever. GG

JetRunner commented 1 year ago

https://github.com/muk-as/DOTA2_CLIENT/blame/113749a7d06a6b6687a445660433ebd1312e803c/game/bin/osx64/libtier0.dylib.txt#L7767

Ok I got it. In 8/30 upgrade, Valve migrated SDL from 2.x to an unstable 3.x version and it breaks the exclusive fullscreen mode. Similar to #1333. I wish someone actually test the game after tweaking stuff..

JetRunner commented 1 year ago

@danginsburg When migrating SDL 2.x to 3.x, is this taken cared of? https://github.com/libsdl-org/SDL/blob/main/docs/README-migration.md?plain=1#L1242-L1246 This seems to be a break change of the exclusive fullscreen API

gpeuc commented 1 year ago

Checked today, 11 September, 16:52 o'clock, the game is still unplayable on MacOS, exclusive full screen doesn't work.

gpeuc commented 1 year ago

Checked again, 15th Sept, exclusive full screen doesn't work. Game still unplayable.