ValveSoftware / Dota2-Gameplay

Public Bug Tracker for Dota2
1.49k stars 87 forks source link

Fantasy Bugs: Neutral Tokens Found and Tormentor Kills are counted incorrectly #12992

Open VirenDias opened 1 year ago

VirenDias commented 1 year ago

Description

Evidence is clearly laid out in this Reddit Post: https://www.reddit.com/r/DotA2/comments/17e9958/fantasy_bugs_neutral_tokens_found_and_tormentor/

Example Match ID (and possibly Timestamp)

No response

Screenshots

No response

Cyborgmatt commented 1 year ago

Judging by the raw data it seems you're correct in your assumptions.

gpk's raw fantasy stats from the Betboom vs Keyd Stars series:

Game 1

    {
      "player_account_id": 480412663,
      "match_id": "7394832000",
      "match_completed": true,
      "team_id": 0,
      "league_id": 0,
      "delay": 0,
      "series_id": 818581,
      "series_type": 1,
      "kills": 8,
      "deaths": 0,
      "cs": 312,
      "gpm": 639.9729,
      "tower_kills": 0,
      "roshan_kills": 0,
      "teamfight_participation": 0.82758623,
      "wards_placed": 1,
      "camps_stacked": 2,
      "runes_grabbed": 12,
      "first_blood": 0,
      "stuns": 32.899963,
      "smokes": 0,
      "neutral_tokens": 3,
      "watchers": 0,
      "lotuses": 0,
      "tormentors": 1,
      "courier_kills": 1,
      "title_stats": "8590033928"
    }

Game 2

       {
      "player_account_id": 480412663,
      "match_id": "7394936686",
      "match_completed": true,
      "team_id": 0,
      "league_id": 0,
      "delay": 0,
      "series_id": 818581,
      "series_type": 1,
      "kills": 4,
      "deaths": 6,
      "cs": 217,
      "gpm": 500.55664,
      "tower_kills": 0,
      "roshan_kills": 0,
      "teamfight_participation": 0.5416667,
      "wards_placed": 2,
      "camps_stacked": 1,
      "runes_grabbed": 7,
      "first_blood": 0,
      "stuns": 60.20136,
      "smokes": 0,
      "neutral_tokens": 3,
      "watchers": 0,
      "lotuses": 0,
      "tormentors": 1,
      "courier_kills": 0,
      "title_stats": "10737442848"
    }

Oli~'s raw fantasy stats from the Talon vs Liquid series:

Game 1

    {
      "player_account_id": 101259972,
      "match_id": "7391463411",
      "match_completed": true,
      "team_id": 0,
      "league_id": 0,
      "delay": 0,
      "series_id": 817884,
      "series_type": 1,
      "kills": 1,
      "deaths": 5,
      "cs": 34,
      "gpm": 185.52582,
      "tower_kills": 0,
      "roshan_kills": 0,
      "teamfight_participation": 0.5,
      "wards_placed": 9,
      "camps_stacked": 1,
      "runes_grabbed": 3,
      "first_blood": 0,
      "stuns": 29.967434,
      "smokes": 6,
      "neutral_tokens": 4,
      "watchers": 9,
      "lotuses": 6,
      "tormentors": 1,
      "courier_kills": 0,
      "title_stats": "545261632"
    }

Game 2

    {
      "player_account_id": 101259972,
      "match_id": "7391525205",
      "match_completed": true,
      "team_id": 0,
      "league_id": 0,
      "delay": 0,
      "series_id": 817884,
      "series_type": 1,
      "kills": 1,
      "deaths": 5,
      "cs": 42,
      "gpm": 232.70941,
      "tower_kills": 0,
      "roshan_kills": 0,
      "teamfight_participation": 0.7,
      "wards_placed": 15,
      "camps_stacked": 4,
      "runes_grabbed": 7,
      "first_blood": 0,
      "stuns": 0,
      "smokes": 7,
      "neutral_tokens": 3,
      "watchers": 3,
      "lotuses": 2,
      "tormentors": 0,
      "courier_kills": 0,
      "title_stats": "547364994"
    }
VirenDias commented 1 year ago

Judging by the raw data it seems you're correct in your assumptions.

Thanks for confirming @Cyborgmatt! May I ask how you get this raw data?

Noxville commented 1 year ago

I noticed that the neutrals weren't counting in the Groups (m_iNeutralTokensFound wasn't updated correctly based on # neutrals found), so I ended up removing the stat from my cards for the playoffs .

Regarding the tormentors, I think it's allocating assists only on units which are actually physically attacking the tormentor - likely because the Unyielding Shield is blocking all damage anyway. Oli cast spells on the Tormentor which effectively did no damage, so he's not deemed a participant (I also had Oli in the Playoffs :<). This is consistent with ~20 Tormentor deaths I looked at the data for: spells didn't seem to count (unless it was the killing damage and you were credited for the kill).

image

In this picture Dawn & Tree were attacking the tormentor but there's no combatlog entries for any damage except the killing blow. Both count as tormentor kills for the players.

VirenDias commented 1 year ago

Oh I see, thanks @Noxville for clearing that up!