ValveSoftware / Dota2-Gameplay

Public Bug Tracker for Dota2
1.49k stars 87 forks source link

Revenant's Brooch active does benefit from Lifesteal and Spell Lifesteal #1824

Closed Hatsura closed 2 years ago

Hatsura commented 2 years ago

Item name

Phantom Province

Description

The 5 attacks from Revenant's Brooch's active ("Phantom Province") does not benefit from any kind of lifesteal source, either physical (tested with Satanic's passive/active) or spell lifesteal (tested w/ Bloodstone's passive/active), This renders this niche item into an extremely bad component on whoever it is supposed to use it (mostly, right-clicking heroes). As a collateral effect, it also renders the useless Bloodstone even more` useless.

Expected results: While active, Revenant's Brooch active should benefit only from Spell Lifesteal (since a spell is active, turning physical into magical attack -- which either way, only benefits from spell lifesteal), be it from normal or critical hits during these 5 attacks, Physical attack lifesteal (including Satanic) should not occur since the 5 attacks are magical damage.

Example Match ID and Timestamp

N/A

TheZett commented 2 years ago

This is "intended" according to older changelogs.

Attack damage requires regular lifesteal to heal you when attacking an enemy, it does not and should not heal from spells (unless they utilise instant attacks). Spell damage requires spell lifesteal to heal you when targeting an enemy, it does not and should not heal from attacks.

Revenant’s Brooch uses magical attack damage, thus you have to buy regular lifesteal to heal off of its attacks.

But the lifesteal mechanic was changed that you are not able to lifesteal off of magical attack damage anymore (a nerf for heroes abusing Javelin & MKB).

This is why you cannot lifesteal at all from Revenant’s Brooch attacks, as magical attack damage is not lifestealable anymore.

Hatsura commented 2 years ago

I see. I didn't knew about this mkb/javelin exploit; I reported this because it is non-intuitive and really kills the viability of Revenant's Brooch in the late game.