ValveSoftware / Dota2-Gameplay

Public Bug Tracker for Dota2
1.48k stars 81 forks source link

PA dagger goes through evasion #2002

Open JQINX opened 2 years ago

JQINX commented 2 years ago

Ability name

stifling dagger

Description

So PA dagger is physical not pure and goes through evasion. I picked invoker with 4 butterflies and Use PA dagger he always gets hit. No miss at all.

Example Match ID (and possibly Timestamp)

Checked in DEMO

TheZett commented 2 years ago

The Dagger has true strike.

Also most spells usually ignore evasion, regardless of damage type.

TheUnholyWrath commented 2 years ago

The Dagger has true strike.

Also most spells usually ignore evasion, regardless of damage type.

Unlike Gods Rebuke, Boundless Strike, Walrus Punch, Normal Punch, Marksmanship,.. Dagger doesn't say it has True Strike anywhere in the tooltip. Bug is either that it has true strike or that it doesn't say "Has True Strike".

JQINX commented 2 years ago

The description said Physical yes. When you use hoodwink acorn shot against butterfly enemy hero they get miss and its damage is also physical. So I though PA physical stifling dagger should also miss based on that analogy.

Sent: Friday, 5 August 2022 5:55 am To: @.> Cc: @.>; @.***> Subject: Re: [ValveSoftware/Dota2-Gameplay] PA dagger goes through evasion (Issue #2002)

The Dagger has true strike.

Also most spells usually ignore evasion, regardless of damage type.

— Reply to this email directly, view it on GitHubhttps://github.com/ValveSoftware/Dota2-Gameplay/issues/2002#issuecomment-1205923746, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2MBFAAPWS7DUHSHI7Q2NO3VXRRBPANCNFSM55TQZGKA. You are receiving this because you authored the thread.Message ID: @.***>

TheZett commented 2 years ago

The description said Physical yes. When you use hoodwink acorn shot against butterfly enemy hero they get miss and its damage is also physical. So I though PA physical stifling dagger should also miss based on that analogy.

Some abilities that utilise instant attacks provide true strike, some do not, this depends on the respective spells. A lot of melee instant attacks usually have true strike, while most ranged instant attacks do not.

List of abilities that utilise instant attacks: https://dota2.fandom.com/wiki/Attack_damage#Instant_Attacks

Despite the Dagger itself being ranged, it applies a melee attack on hit, thus it counts as a melee attack (e.g. can cleave, uses higher bash chance for Basher, etc).

The tooltip could and maybe should mention it, but her Dagger having true strike is most certainly intended.

JQINX commented 1 year ago

Fix the description then. Thanks for your time.

From: @.> Sent: Friday, 5 August 2022 7:27 pm To: @.> Cc: @.>; @.> Subject: Re: [ValveSoftware/Dota2-Gameplay] PA dagger goes through evasion (Issue #2002)

The description said Physical yes. When you use hoodwink acorn shot against butterfly enemy hero they get miss and its damage is also physical. So I though PA physical stifling dagger should also miss based on that analogy. Sent: Friday, 5 August 2022 5:55 am To: @.> Cc: @.>; @.> Subject: Re: [ValveSoftware/Dota2-Gameplay] PA dagger goes through evasion (Issue #2002https://github.com/ValveSoftware/Dota2-Gameplay/issues/2002) The Dagger has true strike. Also most spells usually ignore evasion, regardless of damage type. — Reply to this email directly, view it on GitHub<#2002 (comment)https://github.com/ValveSoftware/Dota2-Gameplay/issues/2002#issuecomment-1205923746>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2MBFAAPWS7DUHSHI7Q2NO3VXRRBPANCNFSM55TQZGKA. You are receiving this because you authored the thread.Message ID: @.>

Some abilities that utilise instant attacks provide true strike, some do not, this depends on the respective spells. A lot of melee instant attacks usually have true strike, while most ranged instant attacks do not.

Despite the Dagger itself being ranged, it applies a melee attack on hit, thus it counts as a melee attack (e.g. can cleave, uses higher bash chance for Basher, etc).

The tooltip could and maybe should mention it, but her Dagger having true strike is most certainly intended.

— Reply to this email directly, view it on GitHubhttps://github.com/ValveSoftware/Dota2-Gameplay/issues/2002#issuecomment-1206518869, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2MBFAGJFU4DUQPMI6BQTL3VXUQDNANCNFSM55TQZGKA. You are receiving this because you authored the thread.Message ID: @.***>