ValveSoftware / Dota2-Gameplay

Public Bug Tracker for Dota2
1.48k stars 81 forks source link

Hand of Midas exploit #21317

Closed drakedog777 closed 2 weeks ago

drakedog777 commented 2 weeks ago

Item name

Hand of Midas

Description

https://www.reddit.com/r/DotA2/comments/1f1hyyl/new_midas_refresh_exploit/

Dropping HoM then buying and instantly selling a new one will refresh the charges on the dropped one.

Example Match ID and Timestamp

N/A

commentator24 commented 2 weeks ago

image please fix this. this is not cool

may i suggest - a temporary fix is to set a stock limit on hand midas to 1 per player/ team or even 5 max just like buying sentries until you guys found a proper solution? this way people cannot abuse this @kisak-valve

maiorescuioandan commented 2 weeks ago

Another one with the same bug: ID 7915168899

Is there any action taken on these players? User ID in question: https://steamcommunity.com/profiles/76561198141315602/

wandfel35 commented 2 weeks ago

thing is its fixed or no? i know how to use this bug but thats just dishonorable. i want to play this game not abuse to easy wins that's what losers would do. 7914969669, 7914879845 my experience.

Skreamex commented 2 weeks ago

temporary fix: if player purchased HoM more than one time, make its sell price 50%

danipralea commented 2 weeks ago

everyone is abusing this. literally every single one of my games has a lot of people abusing this

stefanweiser commented 2 weeks ago

temporary fix: if player purchased HoM more than one time, make its sell price 50%

is this a proposal or a statement?

Skreamex commented 2 weeks ago

temporary fix: if player purchased HoM more than one time, make its sell price 50%

is this a proposal or a statement?

its proposal, sir

stefanweiser commented 2 weeks ago

temporary fix: if player purchased HoM more than one time, make its sell price 50%

is this a proposal or a statement?

its proposal, sir

just hoped that this will get a quick fix today xD, but yes I would support such a quick'n'dirty hack, although I'm not working for them :-(

bwvalve commented 2 weeks ago

This issue should be fixed. Please reopen with a matchID if it happens after the most recent update.

lze81pg1 commented 2 weeks ago

because people who have done this in the past 12 hours are used to using cheats in DOTA, suddenly a free version of cheats is available they gonna abuse it like nobody's business. Just rollback mmr from everybody since 12 hours ago.

LokeLok commented 2 weeks ago

@bwvalve bugged in another way now: https://old.reddit.com/r/DotA2/comments/1f1xl2a/there_is_still_midas_bug_even_after_update_just/

  1. Have Midas in inventory
  2. Buy Midas in stash
  3. Drop Midas from inventory
  4. Sell Midas in stash
  5. Pick up Midas

Midas is also bugged with Tempest Double: https://github.com/ValveSoftware/Dota2-Gameplay/issues/21260

bwvalve commented 2 weeks ago

https://github.com/ValveSoftware/Dota2-Gameplay/issues/21379

fsbahman commented 2 weeks ago

This is one recent match Id that this abuse was used by Ogre in the game: 7915642107

slickbits commented 2 weeks ago

still bugged. just finished the match now. Vengeful enjoying the bug.

21382

bwvalve commented 2 weeks ago

This issue should be fixed (again). Please reopen with a matchID if it happens after the most recent update.

Avarise831 commented 2 weeks ago

This issue should be fixed (again). Please reopen with a matchID if it happens after the most recent update.

Alchemist abuse courier with midas - match id 7915855868

stefanweiser commented 2 weeks ago

@bwvalve Pls reopen. The bug works now like:

put 1st midas into courier -> buy 2nd to stash -> sell 2nd -> get 1st midas

You could limit some items to just one instance per player.

gelo0313 commented 2 weeks ago

@bwvalve

New bug arose.

Other observations.

Here's the video I uploaded on reddit.

stefanweiser commented 2 weeks ago

sounds like the code base is a huge nightmare for the devs

thewitcher123 commented 2 weeks ago

You could limit some items to just one instance per player.

probably this is related to the way it works with Doom and his facet ability to sell items for 90% cost. they should probably investigate more here.

stefanweiser commented 2 weeks ago

@thewitcher123 Nah, in the first seconds after bying something you can sell everything for 100%.

Sheyla998 commented 2 weeks ago

new bug 1h ago, now theyre using heroes to trade midas instead of dropping it, #21398

zamaniafshar commented 2 weeks ago

how about to just lock this item until refactor code base and fix all bugs? it seems the new changes have made the code base so complicated and hard to maintain.

zamaniafshar commented 2 weeks ago

https://www.youtube.com/watch?v=9lWNprULiFQ

dev-cyprium commented 2 weeks ago

@bwvalve please open the issue, still works, in a different way

LiamWalsh98 commented 2 weeks ago

a few things to i have noticed while digging into this.

!! (Only tested in demo and private server)

  1. If a player is in the first server slot (i.e. radiant blue), any use of their Midas will override the cooldown and charges of every single Midas in the game (in all inventories, allied and enemy) to reflect itself.
  2. Any player that is not in the first slot can own multiple Hand of Midas which do not share cooldown with eachother.

This also means that some of these midas bugs' reproducibility would be affected depending on whether or not the hero in server slot 0 is being used.

Also another weird quirk:

In certain cases, when a hero has a Midas in its inventory that is owned by a different hero, its cooldown will tick down 50% slower (i.e. 1s off cooldown for every 2s elapsed). Though it seems that this is resolved when returned; the cooldown jumps back to what it would have been if it was ticking normally.

bwvalve commented 2 weeks ago

This issue should be fixed (again again). Please reopen with a matchID if it happens after the most recent update.

drakedog777 commented 2 weeks ago

Apparently there is a bug with how Octarine Core interacts with Hand of Midas.

It can even cause the Hand of Midas to go into negative charges and crash the game.

https://www.reddit.com/r/DotA2/comments/1f32uk7/new_midas_bug_almost_infinite/

AxisKiku commented 2 weeks ago

@bwvalve Hand of Midas applies CD reduction from Octarine Core every time it is picked up from the ground

21417

gelo0313 commented 2 weeks ago

Hi @bwvalve ,

I don't know how to reopen this thread, so I just created #21419 with Match ID for your review. You may close it as duplicate. :)

gelo0313 commented 2 weeks ago

Hi @bwvalve

I saw the last update but Midas is still not working with Ogre's Multicast. See video below where Multicast x3 was triggered but Midas only worked on a single neutral creep.

Match ID: 7917818284 Time stamp: 0:00:05

https://github.com/user-attachments/assets/6927ec8c-965a-483c-91cf-631b00b2e86d

bwvalve commented 2 weeks ago

Ogre Midas should be fixed in an upcoming update today. Please comment with a MatchID or a video if this issue persists after the next update.

Octarine (and other forms of CDR) issues and Bottle issues should be fixed as of the 2 AM PST patch today. Please comment with a MatchID or a video if this issue is reproducible after the 2 AM patch.

AxisKiku commented 2 weeks ago

Hi @bwvalve there's a new Midas bug and it's easily exploitable #21442

poecco commented 2 weeks ago

just tested this, needs fix https://www.reddit.com/r/DotA2/comments/1f3z7cj/just_checked_bug_with_midas_is_still_in_the_game/

Choose Techies with the Spoon Stash aspect

  1. Buy Midas
  2. Drop and pick Midas
  3. Move between inventory and backpack and use Midas
booshack commented 2 weeks ago

I do not envy you, Dota devs, but surely there is some foundational change you can make to Midas and backpack, instead of coding an exception for every new case that crops up, to save yourself all of this time and effort??

gelo0313 commented 2 weeks ago

Hi @bwvalve

Another bug. Perhaps we can temporarily disable techies from hero pool.

  1. Pick Techies and choose Spoon's Stash Facet
  2. Buy Hand of Midas
  3. Use 2 charges
  4. Move Hand of Midas from inventory to backpack
  5. Move Hand of Midas from backpack to inventory
  6. Bug result: It will instantly refresh Hand of Midas back to 2 charges

Custom Lobby Match ID: 7919344808 In-game Time Stamp: 5:56

https://github.com/user-attachments/assets/c6fa6b72-de66-49d5-bbb3-f739f564d873

Linking to duplicate reports

21450

21442

21451

21452

slickbits commented 2 weeks ago

21468

Still midas bug on techies

ctyar commented 2 weeks ago

I'm not sure it's usefull or not, but another matchID: https://www.opendota.com/matches/7919314467

shaharlinial commented 2 weeks ago

@bwvalve Why do you keep closing these issues? they are still happening.

shaharlinial commented 2 weeks ago

1 Minute ago: https://www.dotabuff.com/matches/7919780173

bwvalve commented 2 weeks ago

Techies Midas should be fixed with the most recent update. Please comment with a MatchID if it persists after the ~12:45 PM Pacific update.

abeninski commented 2 weeks ago

Techie bug happened just now: https://www.opendota.com/matches/7919862688 But maybe the game started before the update?

drakedog777 commented 2 weeks ago

@bwvalve

Morphling can still abuse the Techies Hand of Midas bug when he is morphed into Techies.

bwvalve commented 2 weeks ago

Reopening for Techies + Morphling. Please comment with MatchIDs and/or videos for any other Hand of Midas issues after the ~12:45 PM update.

LokeLok commented 2 weeks ago

The 12:45 PM update, also reintroduced Tempest Double putting allies' Hand of Midas on cooldown bug.

bwvalve commented 2 weeks ago

Current list of issues:

Please comment with MatchIDs and/or videos for any other Hand of Midas issues after the ~12:45 PM update.

Aluerie commented 2 weeks ago

Mechanic of rebuying midas got changed. Steps:

  1. Buy a fresh Midas (it has 1 charge, immediately starts ticking cooldown for the 2nd charge)
  2. Sell Midas
  3. Buy a new midas

Result:

Video was made with host_timescale 10 to be short. But the point is the midas cd wouldn't go past 1 charge ready while being "back in the shop".

https://github.com/user-attachments/assets/09899ae1-3e8c-4c60-b1cd-b789b063a14a

Maybe, it's an intended consequence of fixes but just informing in case it wasn't intentional. Balance-wise it can matter for Doom with Devil's Bargain facet.

Aluerie commented 2 weeks ago

And another thing about (re-)buying midas:

It doesn't have 10 seconds protection timer for accidental purchases anymore - neither the first purchase nor secondaries. Selling price is immediately set to 1100, while there supposed to be 10 seconds where it's allowed to sell it for the full price / fully disassemble it like other items can be.

https://github.com/user-attachments/assets/0a14f44a-875a-4188-847a-7b5c4bc180f7

LokeLok commented 2 weeks ago

Turns out the Tempest Double can also give allies Hand of Midas charges as well: https://www.reddit.com/r/DotA2/comments/1f4s0rs/arc_warden_midas_bug/

Redict commented 2 weeks ago

Next iteration for Lone Druid, different kind of a bug. https://www.reddit.com/r/DotA2/comments/1f4woxs/lone_druid_midas_bug/