ValveSoftware / Dota2-Gameplay

Public Bug Tracker for Dota2
1.49k stars 87 forks source link

Lifesteal/Spell Lifesteal (+Amps) modifiers and functions aren't working - Custom Games #21908

Open JoeGrimes123 opened 2 months ago

JoeGrimes123 commented 2 months ago

Description

Im still new to modding and scripting. https://developer.valvesoftware.com/wiki/Dota_2_Workshop_Tools/Scripting/Abilities_Data_Driven#Actions The site says right there available actions to use, almost all of them working but Lifesteal function does nothing. I created an item for example:

"item_temp_boot"
...
    "Modifiers"
    {
        "modifier_item_temp_boot"
        {
            "Passive"           "1"
            "IsHidden"          "1"
            "Attributes"        "MODIFIER_ATTRIBUTE_PERMANENT | MODIFIER_ATTRIBUTE_MULTIPLE | MODIFIER_ATTRIBUTE_IGNORE_INVULNERABLE"

            "Properties"
            {
                "MODIFIER_PROPERTY_PREATTACK_BONUS_DAMAGE"      "25"
                "MODIFIER_PROPERTY_MOVESPEED_BONUS_CONSTANT"        "1000"
            }
            "OnAttackStart"
            {
                "Lifesteal"
                {
                    "Target"            "CASTER"
                    "LifestealPercent"  "80"
                }
                "Random"
                {
                    "Chance" "20"
                    "OnSuccess"
                    {
                        "Heal"
                        {
                            "Target"        "CASTER"
                            "HealAmount"    "20"
                        }
                    }
                }
                "ApplyModifier"
                {
                    "Target"        "CASTER"
                    "ModifierName"  "modifier_bloodseeker_thirst" // remove 550 movespeed limit
                }
            }
        }
    }

    When I equip a hero with this item, it does as expected, +25 dmg, +1000 ms, heals 20 HP on at 20% chance but the lifesteal just doesnt work.  Same issue with spell lifesteal amplifiers:
    MODIFIER_PROPERTY_SPELL_LIFESTEAL_AMPLIFY_PERCENTAGE,
    MODIFIER_PROPERTY_LIFESTEAL_AMPLIFY_PERCENTAGE,
    I also created lua files for some items thanks to LoD and other custom games where I got my basic knowledge of lua and API.
    function modifier_item_temp_glove:GetModifierLifestealRegenAmplify_Percentage()
    function modifier_item_temp_glove:GetModifierSpellLifestealRegenAmplify_Percentage()

does nothing to a hero. Is it a bug or broken functions due to update?

Example Match ID (and possibly Timestamp)

No response

Screenshots

No response

ION1101 commented 2 months ago

man just write in lua, datadriven has long been outdated