ValveSoftware / Dota2-Gameplay

Public Bug Tracker for Dota2
1.48k stars 87 forks source link

Shadowfiend ult with Aghs return lines add to total fear time instead of a new instance #7159

Open jshare opened 1 year ago

jshare commented 1 year ago

Ability name

Requiem of Souls

Description

The return lines from Aghanim's upgrade go past the cap of 3 lines max fear duration.

image

In the screenshot, the first fear on Bounty Hunter starts at 22:25.67, and ends at 22:32.14, for a total duration of 6.47.

The time difference between when outbound (22:25.67, 22:25.74, 22:26.00) and return (22:26.50, 22:26.50) was only around 0.5s to 1s.

I would expect there to be at most ~4.32s (with Arcane Blink) of fear remaining after the return hits.

Instead it seems like the return hits are increasing the duration of the original fear instance (going past the 3-line cap).

Example Match ID (and possibly Timestamp)

7043236315 22:25

TheUnholyWrath commented 1 year ago

With level 20 talent, arcane blink and timeless relic max fear duration is ~5s. Seems like its working as intended, just op, you're welcome to go investigate yourself but it should be way more obvious if it was exceeding the cap.

jshare commented 1 year ago

The screenshot is just Arcane blink + aghs + talent.

The duration in the screenshot is 6.47 seconds, well more than your stated max of ~5s.

TheUnholyWrath commented 1 year ago

20230305105549_1

Fear Duration Max is the limit on how much getting hit by a soul can fear you for, not a limit on how long you can be feared in total. The fear will be reapplied on your hero (for every soul that hits you) until the final soul hits you, then you will be feared for Fear Duration Max seconds.

20230305110212_1

You can go back and watch this debuff, its getting reapplied until the souls retreat and stop hitting bounty.

jshare commented 1 year ago

Well, the wiki says 3 lines is the cap. ("The duration increases by 0.9 (Talent 1.2) per each line hit, but is capped at 2.7 (Talent 3.6) seconds."). If that is not true, then fine.

If it is true, then the intent seems to be a max of 3.6s base, but what happens with Aghs is 7.2s base (assuming 3 hits each way).

TheUnholyWrath commented 1 year ago

The wiki is correct, you're misinterpreting what Fear Duration Max means.

If you get hit by 1 line you get feared for 0.9s, get hit by 2 lines is 1.8s, get hit by 3 lines is 2.7s, get hit by 4 lines 2.7s,... every time you get hit after getting hit 3 times, you are feared for 2.7s. The important part is that the 2.7s refreshes for every subsequent line you are hit by. The aghs is not treated separately, you're just getting hit by more lines, refreshing that 2.7s again. Does that make sense?

So why does the fear last so long then? The talent makes the base fear max duration 3.9s. Arcane Blink and Timeless Relic both add 20% so the max fear duration ends up at over 5s. You only need 4 lines to hit you for a 5s fear. The very last line that hits you will reapply that 5s fear, easily 1-2s after the inital fear, totalling a 6-7s fear duration.

The only thing the cap affects in the total fear duration is how long you are feared after the lines stop hitting you, because it is the maximum value that a single line can fear you for.

Please go back and watch the replay or test this out yourself with this in mind. You can see the debuff that says feared getting reapplied by every line that hits you, you can ping it and see that this value isn't increasing, and is massively amped by the talent with debuff amp.

jshare commented 1 year ago

Ok, there's nothing to indicate that subsequent lines refresh the fear. That is what is happening with the aghs, with the return lines refreshing it. If that is intended, then fine.

What would I look at to "see the debuff that says feared getting reapplied by every line that hits you" ? The combat log only shows it starting and stopping.

TheUnholyWrath commented 1 year ago

20230305110212_1

jshare commented 1 year ago

I still can't get the math to work. Max duration from the last line should be 3.6 (with talent) 1.2 1.2 , which is 5.184, but 32.14 - 26.5 = 5.64

TheUnholyWrath commented 1 year ago

The talent got buffed a while ago, the wiki would be out of date. Its 3.9 now not 3.6

TheUnholyWrath commented 1 year ago

Okay I'm dead wrong about the history and seems like theres a bug here. 7.32d was supposed to nerf it from +0.4s/+1.2s to +0.3s/+0.9. Its now +0.3s/+1.2s

jshare commented 1 year ago

In demo mode (for what it's worth), I am consistently getting 3.9s base with various amps, talent, and point blank ult.

Without talent it is 2.7s base. So I think talent is doing +0.4s. At least in demo.

TheUnholyWrath commented 1 year ago

I'll make a separate issue for the talent bug once we're done here since this is pretty cluttered and off topic. When you take the talent Fear Duration Max goes from 2.7 to 3.9. That should help the math line up. Is there anything you still think is a bug in here or can we close this issue?

jshare commented 1 year ago

This makes sense to me at this point. I will see how hard it is to update the wiki to more explictly say that each line starts a new fear debuff on impact, instead of each line increases the fear duration.