ValveSoftware / Dota2-Gameplay

Public Bug Tracker for Dota2
1.48k stars 87 forks source link

Arcanas Hero Voice chat still using default hero set voice sound #93

Closed beinelemental closed 1 year ago

beinelemental commented 2 years ago

Arcana set still using its default hero voice sound and also Persona set hero voice chat text doesn't match with the actual voice sound.

NMOTH commented 2 years ago

Arcana set still using its default hero voice sound and also Persona set hero voice chat text doesn't match with the actual voice sound.

can you provide screen recording? Is it all heroes with arcanas or specific heroes with arcanas?

Aluerie commented 2 years ago
  1. Arcanas with altered voice filter do not have it applied to Dota+ Hero Chat Wheel voice lines PA, LC, TB, SF, Zeus, MK, Jugg, Rubick, Ogre
  2. Arcanas with completely new voice pack still use Dota+ Hero Chat Wheel of the base hero Pudge, Shaker, WK, QoP, WR, Spectre, Drow

And remaining arcanas (Techies, Lina, CM, Io with ~5 extra Portal reference lines) dont change anything related to voice.

Example: PA https://youtu.be/3w6_cI2G-NA This is probably the most noticeable one because her base model uses just normal human voice and arcana has this "phantom distorted" VO filter.

Edit: it is a bit inconsistent, in my last game I heard Jugg voice line from Dota+ Wheel having arcana filter (as it should) and some of comments/issues on this repo say that some lines are fine and some are not.

PrzemekSkretowski commented 2 years ago

I believe it actually never worked. Newer arcana, or hero voice packs (like jugg or spectre) would probably require new sets of voice lines, just like personas. That said, if we can't get the new sets of voice lines, adding filters to the older ones would still be awesome.

zezobest commented 2 years ago

rubick dota+Hero Chat Wheel voice lines level 30 its only default hero voice sound even with arcana

KingRyusei commented 2 years ago

I noticed that since I got to Level 30 on Ogre Magi that his "Oh Skillshot" line is from his Arcana's voice pack and not his default model while all his lines from Dota Plus are from the default model as well.

jeffhill commented 2 years ago

The fix for Phantom Assassin and Drow Ranger will be in the hotfix shipping shortly. Phantom Assassin uses the processed version of her lines when equipped with the arcana and Drow Ranger has a different selection of lines for the chat wheel with the arcana equipped.

We'll need to go through all the arcanas or voice packs to annotate them for this feature correctly, but we wanted to get two of the most obvious cases done and shipped.

jeffhill commented 2 years ago

Ok, I think all the rest of the arcanas are done now (it's been a lot of typing in data files for the past day or so). I had to make some editorial decisions in cases where there weren't processed lines to do 1-1 replacements. I prioritized getting all the arcana "done" to the point of having the correct VO source for each arcana, and then if we should swap some lines around next week, we can do that.

I'm going to leave this issue open for now, in case we've missed someone who needs a set of replacements, or if anyone's got suggestions for better line replacement choices than the ones we've just shipped.

Astiberon commented 2 years ago

I'm going to leave this issue open for now, in case we've missed someone who needs a set of replacements, or if anyone's got suggestions for better line replacement choices than the ones we've just shipped.

Thank you Jeff and your team for a job well done. I have one question: Please tell me, does Rubik's phrase at lvl 30 sound like Arcana's voice? I can't check it myself unfortunately. Sorry for my English.

PrzemekSkretowski commented 2 years ago

The work you did is just wonderful, I've been waiting ages for PA to speak with the arcana voice, but you did so much more, and it's just beautiful. Thanks Jeff and the gang!

I'm going to leave this issue open for now, in case we've missed someone who needs a set of replacements, or if anyone's got suggestions for better line replacement choices than the ones we've just shipped.

You did a really good job with replacements, arcana Jugg is literally my new favorite. I've checked the voice lines to see if there are any better ones, and oh boy, it is hard to pick something out of so many good ones. That said, I always thought the kit of QoP is kinda boring, these are the lines I've found somehow interesting:

You're simply not worthy. Why am I even talking to you? While we were doing this, your team was busy losing. You don't even deserve to look at me. You call that a fight? Your agony is my ecstasy. Yeah, okay. My bad. Your queen saves the team.

Other than that, I would change Drow's line, "There's only one way to see behind the eyes." to something cooler, like:

I don't care who you are. I just need you to die. I like to be honest. You are all going to die. Quiet now. Let's just call it murder. Tell me: was it worth it?

The rest of her set is pure gold.

Spectre, Skelly King, and Windranger also seem fun, I noticed ES doesn't have anything new, but I guess that's what's coming next week. I would also like to mention, that as LC player, I really love her set of lines, but she deserves better than "Augh!" at grandmaster tier, actually reddit had to remind me of that, because it's so forgettable.

That said, it's hard to suggest something, because it's personal taste after all. Personally, I find the new voice lines awesome. Probably there will be some people unhappy with new decisions, so separating the voice packs (like Jugg or Spec) would be the best option, so everyone could pick their favorite, but I don't know if it's not too much work. I would love to use Mirana's persona voice on my default Mirana.

Alright, that's it, thanks once again for your amazing job, time to grind that grandmaster Jugg!

Oh, and don't you dare change "Easy" on Jugg to something else!

LokeLok commented 2 years ago

I found all the lines you missed, were you can still do a 1-1 replacement.

Juggernaut:

Ogre Magi:

Pudge

Queen of Pain:

Spectre:

Windranger:

Wraith King:

Astiberon commented 2 years ago

If I'm not mistaken, there are 3 items that change the hero's voice. This, of course, is not so important, but it would be nice if these phrases were also added to the wheel. [Axe] - Fists of Axe Unleashed [Sniper] - Helm of the Ardalan Interdictor [Tiny] - Majesty of the Colossus

LokeLok commented 2 years ago

Here are some lines that has the potential to replace some of the lines you chose . I like when the lines goes well together with the spells of the hero, or if they can be used in combination with other lines. Here is my take on some lines.

Juggernaut

Spectre

Windranger

Cymen90 commented 2 years ago

Opinion. WR's "Must have hit pretty close to the mark to get them all riled up like that." - is a weird line, not even sure when to use that :D

Hard disagree, it is one of the best lines to use after successfully tilting the enemy into a rage-buyback or worse.

CFCyrus commented 2 years ago

I am still having issues with QOP arcana and also re-posted an issue on this.

https://github.com/ValveSoftware/Dota2-Gameplay/issues/3047

Any fix? I have recent gameplay exhibiting how the arcana game voice and voice lines only work when i equip a base back item. Once I equip the arcana back item the voices (both) change to the "vanilla QOP voice".

Any suggestions - its my fav arcana and I have tried everything.

beinelemental commented 2 years ago

I will reopen this issue and will leave Jeff to decide when will this case appropriately can be close.

andrewtruong6123 commented 2 years ago

Rubick grandmaster's voice line still uses the default voice line, but all the others use the arcana.

bwvalve commented 1 year ago

Rubick's grandmaster voice line will use the arcana voice in an upcoming update.

CFCyrus commented 3 months ago

Good day gents.

Still having an issue with QOP Arcana (for around a year now). Acrana voice plays if standard back equipped and vice versa if Arcana back is equipped.

Have tried everything. Impacts both ingame voice as well as voice wheel.

Please help? Tried everything under the sun, no fix in sight.

https://github.com/ValveSoftware/Dota2-Gameplay/assets/112467129/b7b78d71-a3ff-4b71-8d36-a2384dc4d1d3

https://github.com/ValveSoftware/Dota2-Gameplay/assets/112467129/d77abdc6-4310-46a2-bf7f-624623adad61

herlocksholmes1 commented 1 month ago

Sniper's Helm of the Ardalan Interdictors still doesn't change chat wheel voice lines as of today (not teammate voice lines, nor all chat lines).