search

ValveSoftware / Fossilize

A serialization format for various persistent Vulkan object types.
MIT License
585 stars 47 forks source link

[steam] fossilize_replay stops processes and fails to resume them #234

Closed Obbi89 closed 1 year ago

Obbi89 commented 1 year ago

I see this iregularily since turning off background processing. When starting CS:GO and shaders have to be pre-cached fossilize replay stops processes while processing but never resumes them. (I have not seen this with any other games so far, but I don't think its related to the game)

I can either abort the game launch and resume or send SIGCONT to the stopped processes by hand to continue the processing. It is always a single process that is stopped and it is preventing reaping of other processes. So it's like nproc-1 zombies + 1 stopped process.

I can only guess what is causing this, but maybe the internal accounting (stopped/running jobs) is not working correctly. Please let me know if you need further information.

HansKristian-Work commented 1 year ago

This should be fixed on master. I found and fixed some potential deadlocks.

theHamsta commented 1 year ago

Replying to https://github.com/ValveSoftware/Fossilize/issues/234#issue-1910315059

Could you provide the Vulkan driver version with which this issue is occurring? E.g. nvidia-smi when using proprietary Nvidia driver.

Riesi commented 1 year ago

Can confirm that replay now finishes when running CS2. :tada:

Obbi89 commented 1 year ago

Replying to #234 (comment)

Could you provide the Vulkan driver version with which this issue is occurring? E.g. nvidia-smi when using proprietary Nvidia driver.

I was running on the stable driver at that time. Which should've been: 535.113.01 (at least according to my logs I installed this one 2 days before)

Now I'm running: 545.29.02

And the issue seems to be gone. Could compile all shaders sucessfully without hiccups. My guess, this is fixed. Thanks.