search

ValveSoftware / Proton

Compatibility tool for Steam Play based on Wine and additional components
Other
23.42k stars 1.02k forks source link

glslang should be a git submodule #29

Open flukejones opened 5 years ago

flukejones commented 5 years ago

I notice that glslangValidator is precompiled - this should probably be a git submodule to allow for easier building on macOS (and other Linux distros).

cjwijtmans commented 5 years ago

i agree. i was wondering why this is not a submodule.

peterson432 commented 5 years ago

yea, glslang validator is pre-compiled and it creates a difficulty for building an mac OS and linux, it should be a submodule for easier access.

jbmagination commented 4 years ago

Just a note, two years in the future: macOS is not a Linux distro. It is a Unix-based operating system, while Linux is a Unix-based kernel. macOS does not run Linux, it runs Unix.

flukejones commented 4 years ago

Just a note, two years in the future: macOS is not a Linux distro. It is a Unix-based operating system, while Linux is a Unix-based kernel. macOS does not run Linux, it runs Unix.

What was the point of this reply other than to be correct? The initial issue post was a mistype and everyone else seemed to get the point.

cjwijtmans commented 4 years ago

Just a note, two years in the future: macOS is not a Linux distro. It is a Unix-based operating system, while Linux is a Unix-based kernel. macOS does not run Linux, it runs Unix.

(L)inux (I)s (N)ot (U)ni(X)

flukejones commented 4 years ago

Christ... unsubscribe

jbmagination commented 4 years ago

The point was so that people could be informed, I'm sure someone out there probably might assume that. Yeah, likely a good idea to unsubscribe. Sorry!

cjwijtmans commented 4 years ago

The point was so that people could be informed, I'm sure someone out there probably might assume that. Yeah, likely a good idea to unsubscribe. Sorry!

Except you are totally incorrect but ok.