search

ValveSoftware / Proton

Compatibility tool for Steam Play based on Wine and additional components
Other
23.91k stars 1.04k forks source link

Black Desert (582660) #3620

Open Newbytee opened 4 years ago

Newbytee commented 4 years ago

Compatibility Report

System Information

I confirm:

steam-582660.log

Symptoms

Registration window appears, which works, however after restarting the game once (it crashed the first time during registration) and registering again plus verifying, this happens: image

Reproduction

  1. Attempt to play the game
Etaash-mathamsetty commented 7 months ago

Replying to https://github.com/ValveSoftware/Proton/issues/3620#issuecomment-1902686806

sorry I was on mobile, providing links: https://gitlab.winehq.org/etaash.mathamsetty/wine/-/commit/08d8187c2acb0e43b5ca505a95a819cc3fdb55d7 screenshot: image

Etaash-mathamsetty commented 7 months ago

Replying to https://github.com/ValveSoftware/Proton/issues/3620#issuecomment-1902688329

wdym blank window better screenshot after it loaded: image

Daktyl198 commented 7 months ago

Please edit your comments rather than commenting several times. It spams emails to those watching the issue.

Based on the code he changed, it seems as if the rendering code was being passed a bad drawing surface handler, and not properly erroring out. Thus, black screen (as all of the draw calls failed).

Etaash-mathamsetty commented 7 months ago

Please edit your comments rather than commenting several times. It spams emails to those watching the issue.

Based on the code he changed, it seems as if the rendering code was being passed a bad drawing surface handler, and not properly erroring out. Thus, black screen (as all of the draw calls failed).

my github is bugging out, blame github

AkechiShiro commented 7 months ago

When will your fix @Etaash-mathamsetty, be available in Wine 9.0.0 ? We should probably compile wine from git in order to have it on our side. But it's not available in Proton Experimental.

Daktyl198 commented 7 months ago

Somebody should submit the patch to Proton-GE and Proton specifically, as well as wine. If you just submit it to wine, it'll take ages to work it's way into Proton Experimental.

Etaash-mathamsetty commented 7 months ago

When will your fix @Etaash-mathamsetty, be available in Wine 9.0.0 ? We should probably compile wine from git in order to have it on our side. But it's not available in Proton Experimental.

it's more of a hack right now, i need to test the behavior on windows and see if it does the same thing.

AkechiShiro commented 7 months ago

@Daktyl198 @Etaash-mathamsetty already tried to submit one patch (not the whole fix) but it was refused and he was told to put it upstream : https://github.com/ValveSoftware/wine/pull/217

Etaash-mathamsetty commented 7 months ago

@Daktyl198 @Etaash-mathamsetty already tried to submit it as a patch but it was refused and he was told to put it upstream : ValveSoftware/wine#217

that's not the same patch

Daktyl198 commented 7 months ago

As mentioned, not the correct patch. Valve might not take it the correct patch even, but the Proton-GE dev might. He includes much more "hacky" fixes for specific games, which might help us run it while a proper fix is worked out.

AkechiShiro commented 7 months ago

Yes you are both correct, but the fix is 2 commits (only the last one is necessary I believe) :

I'd prefer to have both even if they're hacky, it's better to have something that works "hacky" than something broken, I'd say.

patofet commented 7 months ago

Finally, I reproduced the crash:

wine: Call from 00000002C73AC5E5 to unimplemented function win32u.dll.NtGdiDdDDINetDispQueryMiracastDisplayDeviceStatus, aborting

GLib-GObject-CRITICAL **: 16:22:55.779: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

It appears that the game behaves differently based on the screen setup. When playing on the Steam Deck's screen, everything seems to work fine. However, upon connecting an external screen using a dock, issues arise. It's an interesting observation that might point to a specific compatibility or configuration challenge. If anyone has insights or suggestions on optimizing Black Desert for an external screen setup, I'd love to hear them!

LexaproDelirium commented 7 months ago

anyone reached to ge yet? i don't wanna ping him again for the same thing

Etaash-mathamsetty commented 7 months ago

anyone reached to ge yet? i don't wanna ping him again for the same thing

Me and GE are in touch, he knows

ruineka commented 7 months ago

I see this here https://github.com/GloriousEggroll/proton-ge-custom/commit/7d7e959a416ede062d29038930871633aa1bade8

wescode commented 7 months ago

anyone reached to ge yet? i don't wanna ping him again for the same thing

Me and GE are in touch, he knows

Thanks for the quick fix. I wanted to add that the launcher can still crash under certain circumstances. If you login and then click the gear icon at the top right, then apply or close that window, it freezes the launcher.

Etaash-mathamsetty commented 7 months ago

anyone reached to ge yet? i don't wanna ping him again for the same thing

Me and GE are in touch, he knows

Thanks for the quick fix. I wanted to add that the launcher can still crash under certain circumstances. If you login and then click the gear icon at the top right, then apply or close that window, it freezes the launcher.

I have a fix for that as well, but my laptop is really slow at compiling code. I finally got my pc up and running and I'll test on it once my school is done. Poor thing's CPU failed, and I'll have to return the tester CPU that's in it right now :(

Etaash-mathamsetty commented 7 months ago

proper fix is here: https://gitlab.winehq.org/wine/wine/-/merge_requests/4912 (made by valve/codeweavers, not me) and it fixes the issues with my patch, such as crashing settings :)

gofman commented 7 months ago

The launcher should hopefully work in just updated Proton Experimental ([bleeding-edge] Beta branch).

Etaash-mathamsetty commented 7 months ago

The launcher should hopefully work in just updated Proton Experimental ([bleeding-edge] Beta branch).

it updates that quick? damn

wescode commented 7 months ago

Has anyone made any progress on the market? I'm not sure where to look next, outside of the winhttp data. If anyone has any other clues on where to look(other dlls to trace etc), please share.

psychomantium commented 7 months ago

Has anyone made any progress on the market? I'm not sure where to look next, outside of the winhttp data. If anyone has any other clues on where to look(other dlls to trace etc), please share.

I'm not sure if this is useless info or not, but BDO uses coherent_ui.exe or at least used it for all kind of interface/web functions, not sure if this can be helpful to some people here who knows more. Not sure if this can be relevant?

jwolz commented 7 months ago
  • The game will make a POST request to /Trademarket/GetMyWalletList. It's POST data is something like: {"userNo":"12345","certifiedKey":"","type":"0"} The response is not ascii, it seems like possibly it's encrypted. Interestingly the retrieved bytes is the same size as the log complains about: winhttp:read_data retrieved 486 bytes (1012/1012) log: WorldMarket processJSON Fail size(1012) != originalsize(0), type(8)"

Maybe a dumb question: Could it also be that the response is compressed? (gzip?)

The reason why I had this idea: I checked with my browser's devtools (F12) what the web central market does (usually you would use the same REST endpoints...).

It calls a /Home/GetMyWalletList endpoint (and a few others). All JSON responses are gzip compressed.

If the decompression fails for some reason with wine, it may explain the "encryption". But just a idea.

wescode commented 7 months ago

Replying to https://github.com/ValveSoftware/Proton/issues/3620#issuecomment-1906822779

Yea, it's binary. The return header is: winhttp:process_header L"Content-Type": L"application/octet-stream" 0x20000000

gofman commented 7 months ago

I am looking into this and it is basically clear what issue is about (unrelated to http conversation per se). I hope to fix it rather soon in Proton.

gofman commented 7 months ago

Market should work with the just updated Experimental ([bleeding-edge] branch) now, or at least I can open the market and it shows some stuff in it.

aveenhof commented 7 months ago

Market should work with the just updated Experimental ([bleeding-edge] branch) now, or at least I can open the market and it shows some stuff in it.

Confirming this is now functioning properly on Proton Experimental. Marketplace and Warehouse both fully functional on Steam Deck SteamOS with Proton Experimental. Thank you so very much!

Black Spirit's Adventure appears to still not work but this is substantially less impactful and less urgent. Thought it was worth noting, however, that the BSA window is blank.

Thanks again gofman, returning to BDO because of you. Much appreciated.

gofman commented 7 months ago

Black Spirit's Adventure appears to still not work but this is substantially less impactful and less urgent. Thought it was worth noting, however, that the BSA window is blank.

If you can describe what is Black Spirit's Adventure and BSA window, and how exactly to get there in a quickest possible way, for people who don't know how to play the game and know nothing / don't have a character, that will probably be helpful.

aveenhof commented 7 months ago

Black Spirit's Adventure appears to still not work but this is substantially less impactful and less urgent. Thought it was worth noting, however, that the BSA window is blank.

If you can describe what is Black Spirit's Adventure and BSA window, and how exactly to get there in a quickest possible way, for people who don't play the game and know nothing / don't have a character, that will probably be helpful.

Happy to. It's a daily roulette sort of mechanic, very typical of BDO. It's a sort of daily login reward. Certainly not game breaking.

I am not sure if you can access this without at least having a character. However, once in-game, there are a couple of ways to access it. I will try to attach some screenshots showing exactly how. I had to xfer these from Steam Deck to PC so let me know if the resolution is bad and I can try again:

image image

edit to include: image of blank BSA window:

image

vevota commented 7 months ago

Thanks for your work on the launcher and market.

Another window that doesn't work is the "Setting Archive" window in settings.

You're able to upload your settings and custom ui to the cloud, and download them. It shows a blank screen when you click it. image What it usually looks like image

wescode commented 7 months ago

Oddly enough the black spirit adventure and other web based windows were working for me previously. Now they are all blank as above. You can however still click on the buttons, similar to the issues the launcher had. Also, the market seems to be working now, thanks for the quick fix!

Daktyl198 commented 7 months ago

Have you tried popping the black spirit adventure window out into its own floating system window using the paper-looking icon on its title bar? I know that used to fix rendering issues for me on Windows.

wescode commented 7 months ago

Floating the window didn't help. I did however recompile wine-ge-custom 8-25 with the two patches for launcher/market and black spirit adventure works fine. So this must be something specific to proton experimental. There also seems to be some other differences with experimental(not surprising I guess), but loading into the game is noticeably slower.

gofman commented 7 months ago

@aveenhof @vevota Thanks for the info. Those windows should hopefully work in the just updated Proton Experimental ([bleeding-edge] branch).

aveenhof commented 7 months ago

@aveenhof @vevota Thanks for the info. Those windows should hopefully work in the just updated Proton Experimental ([bleeding-edge] branch).

Confirming the window is now rendering as expected on Proton Experimental through Steam Deck (SteamOS, Steam version of BDO).

Once again, thank you very much @gofman for the quick fix. I'll let others pop in if they are experiencing any further issues. I can't believe this was resolved so quickly after BDO becoming workable with Linux. You have my sincere gratitude.

edit to add: any Steam Deck users experiencing crashes, enter "settings" on the game start screen before server selection and disable "low power mode". This automatically re-enables on every launch, but disabling it has prevented me from crashing. Seems like something Proton cannot address but has fixed the crashing issue for me.

dron-wic commented 7 months ago

Can you tell me how to fix the game self-closing 1-2 minutes after startup? Tried proton experimental and GE-8.25 - does not help. Version of the game is not steam, for ru region.

GloriousEggroll commented 7 months ago

Can you tell me how to fix the game self-closing 1-2 minutes after startup? Tried proton experimental and GE-8.25 - does not help. Version of the game is not steam, for ru region.

Steam version and Standalone NA version are working fine here. My guess is RU region maybe has some other kind of anticheat that's not supported. Only the steam version is within scope of support here.

AyoungDukie commented 7 months ago

Can you tell me how to fix the game self-closing 1-2 minutes after startup? Tried proton experimental and GE-8.25 - does not help. Version of the game is not steam, for ru region.

Is this a home PC or a Steam Deck? If a PC, what Distro are you running, and If not via Steam, how was it installed? Does running with a Steam-based installation work?

The more info you can provide, the more can be done to efficiently identify a problem, or otherwise point you to a place thay can. As stated above, this thread is focused on running the game via Steam install.

dron-wic commented 7 months ago

Can you tell me how to fix the game self-closing 1-2 minutes after startup? Tried proton experimental and GE-8.25 - does not help. Version of the game is not steam, for ru region.

Is this a home PC or a Steam Deck? If a PC, what Distro are you running, and If not via Steam, how was it installed? Does running with a Steam-based installation work?

The more info you can provide, the more can be done to efficiently identify a problem, or otherwise point you to a place thay can. As stated above, this thread is focused on running the game via Steam install.

I rolled back from the beta version to a stable steam os, also disabled tearing, dynamic shading and scaling mode (all parameters are selected through the three-dot button) - the problem seems to have gone, just so out of the game does not throw out.

The game was installed on pc, then transferred to steam deck via file zilla. I'm not really interested in the steam version because I need a different account for the game (not the one in steam).

aveenhof commented 7 months ago

Can you tell me how to fix the game self-closing 1-2 minutes after startup? Tried proton experimental and GE-8.25 - does not help. Version of the game is not steam, for ru region.

Steam version and Standalone NA version are working fine here. My guess is RU region maybe has some other kind of anticheat that's not supported. Only the steam version is within scope of support here.

I saw the issue as well previously, NA Steam Deck Steam install. I believe I was able to get it fixed by lowering all graphics settings, disabling all tearing / shading settings, turning off lower power option and fps limiting. In the few seconds before it crashed it ran beautifully so I am not sure why what I did fixed the issue, but it seems to have solved it for me.

Granted I have yet to spend an extended period in-game so I may have gotten lucky. Just calling out that myself and others did see it on NA as well so it is not Russian anti cheat related.

Happy to assist if there's anything I can do to help.

dron-wic commented 7 months ago

Replying to https://github.com/ValveSoftware/Proton/issues/3620#issuecomment-1908869068

The game threw out again, but after 5-10 minutes of being in the game, now I will try to lower all the graphics settings to the lowest. thanks for the advice.

aveenhof commented 7 months ago

Replying to https://github.com/ValveSoftware/Proton/issues/3620#issuecomment-1908871491

Of course. I also noticed settings are reverted / not saved on relaunch. So for now you will need to adjust these settings on the start screen every time you enter the game.

dhyanpatel commented 7 months ago

Also running into this issue. Game crashes after 3-5 minutes. Setting all graphics to low and turning off the lower power option. I'm currently going through the tutorial, so I'm not sure if this is relevant to regular gameplay, or if it's caused by any scripts that run during the tutorial.

TheWyn commented 7 months ago

Trying out standalone NA client on Arch with nvidia proprietary drivers and bleeding edge proton..marketplace works, black spirits adventure and setting archive are blank screens. Not turning off low power mode in settings before character select it's a guaranteed crash after choosing character. No issue with launcher.

Ezyrath commented 7 months ago

Trying out standalone NA client on Arch with nvidia proprietary drivers and bleeding edge proton..marketplace works, black spirits adventure and setting archive are blank screens. Not turning off low power mode in settings before character select it's a guaranteed crash after choosing character. No issue with launcher.

For the standalone NA/EU client, force proton to use the specific patch for the game with the launch command SteamGameId=582660 %command%

TheWyn commented 7 months ago

Thanks, works now

On January 25, 2024 12:11:42 p.m. EST, Loanne LUCOTTE @.***> wrote:

Trying out standalone NA client on Arch with nvidia proprietary drivers and bleeding edge proton..marketplace works, black spirits adventure and setting archive are blank screens. Not turning off low power mode in settings before character select it's a guaranteed crash after choosing character. No issue with launcher.

For the standalone NA/EU client, force proton to use the specific patch for the game with the launch command SteamGameId=582660 %command%

-- Reply to this email directly or view it on GitHub: https://github.com/ValveSoftware/Proton/issues/3620#issuecomment-1910638560 You are receiving this because you commented.

Message ID: @.***>

aveenhof commented 7 months ago

I was mistaken before -- was just getting lucky. Game is crashing constantly on Steam Deck and cannot seem to find any workaround in settings.

Sometimes I can play for a few minutes, sometimes it crashes instantly. Never in-game more than 10-20 minutes or so before a crash.

Not sure what could be causing but happy to provide any additional info that might be helpful. TIA for anyone who is aware of a workaround/resolution!

HLennart commented 7 months ago

I can confirm constant crashes on steam deck, sometimes it happens just when ideling ingame, often times it triggers on ingame settings changed

patofet commented 7 months ago

I can confirm constant crashes on steam deck, sometimes it happens just when ideling ingame, often times it triggers on ingame settings changed

I had to install another linux distro in order to play, with another distro works perfect

HLennart commented 7 months ago

I can confirm constant crashes on steam deck, sometimes it happens just when ideling ingame, often times it triggers on ingame settings changed

I had to install another linux distro in order to play, with another distro works perfect

Is that on the deck or PC? can you list the steps you took?