search

ValveSoftware / Proton

Compatibility tool for Steam Play based on Wine and additional components
Other
23.88k stars 1.04k forks source link

Mafia Definitive Edition (1030840) #4220

Open McMarius11 opened 3 years ago

McMarius11 commented 3 years ago

Compatibility Report

System Information

I confirm:

steam-1030840.log

Symptoms

game crashes without an error

Reproduction

start the game

ga2mer commented 3 years ago

Game has useless launcher and it doesn't needed, so you can rename launcher.exe to something.exe and rename mafiadefinitiveedition.exe to launcher.exe But game also doesn't work and I think it's denuvo and I got activation limit, so can test only tomorrow, but before limit I did simple and relay logs simple_steam-1030840.log relay_steam-1030840.tar.gz

kernle32dll commented 3 years ago

Looking at Mafia 3 (and its definitive edition) - which basically uses a similar engine... what pops into my mind is the need to adjust its config by hand, before the game can launch. I tried that after exe rename shenanigans, but I could not find the game writing a config file at the expected location.

valters-tomsons commented 3 years ago

I used all my activations for today but found out this game saves configuration to Documents instead of AppData.

/1030840/pfx/drive_c/users/steamuser/My Documents/My Games/Mafia Definitive Edition/Saves/launcconfig.cfg

Initial content for this file is 0 0 0 for me, hope this helps.

ga2mer commented 3 years ago

Thanks Paul for patches in game with similar issue, now it's running

Be careful, game has denuvo with 5 activation limit (means 5 unsuccessful launches) for 24 hours

Proton build may have issues with glibc, so before launch Mafia, try this build with other non-denuvo games

Screenshot ![Screenshot_20200926_214404](https://user-images.githubusercontent.com/1492335/94405858-d15aee00-0179-11eb-89c1-e4406b2ffc1f.png)
kubapet commented 3 years ago

@ga2mer Hi, do you have the sources of the build somewhere? I m running on opensuse and I only have glibc 2.31 and the proton build you linked is compiled against 2.32 so it doesn't run on my end :(

xDShot commented 3 years ago

You can try https://github.com/Frogging-Family/wine-tkg-git Apply only first patch from patchset.

xDShot commented 3 years ago

Media Foundation issue as usual - black cutscenes

kubapet commented 3 years ago

@xDShot you mean only server-Support-noname-named-pipes ?

FaramosCZ commented 3 years ago

Can you please explain it "for dummies" to me, please? :)

I have Fedora 32 (fully up-to-date). I have NVidia GTX 1060 GPU and its packages installed:

xorg-x11-drv-nvidia-libs-450.66-2.fc32.i686
xorg-x11-drv-nvidia-cuda-libs-450.66-2.fc32.x86_64
kmod-nvidia-5.8.11-200.fc32.x86_64-450.66-1.fc32.x86_64
xorg-x11-drv-nvidia-450.66-2.fc32.x86_64
nvidia-persistenced-450.66-1.fc32.x86_64
xorg-x11-drv-nvidia-kmodsrc-450.66-2.fc32.x86_64
xorg-x11-drv-nvidia-cuda-450.66-2.fc32.x86_64
xorg-x11-drv-nvidia-libs-450.66-2.fc32.x86_64
nvidia-settings-450.66-1.fc32.x86_64
xorg-x11-drv-nvidia-cuda-libs-450.66-2.fc32.i686

Installed Steam steam-1.0.0.66-2.fc32.i686 Installed "Mafia: Definitive Edition" inside Steam. I have single monitor connected to the PC with 4k resolution (3840 x 2160 px)

I still does not work and I don't know what else (and how) can I do. I looked at the repository, but I don't know how to build it ... and where ... (I don't see any Makefile ?)

You can try https://github.com/Frogging-Family/wine-tkg-git

I assume the patches you had in mind were these:

Thanks Paul for patches in game with similar issue, now it's running

But I again don't understand where and when to apply them.

I launch the game with the big green PLAY button in Steam. I don't get any error messages or anything when the game crashes and I don't know where to look for some logs from the crashes.

Here: https://github.com/ValveSoftware/Proton/issues/4168#issuecomment-695025232 the folk also said something about:

The game was playable for me on Nvidia with the following additional workarounds:

Fake AMD video card through dxgi (that is doable by putting dxvk.conf with dxgi.nvapiHack = True to the game directory and using dxvk's or Proton's dxgi.
Use native d3dcompiler_47 override.

But I don´t know how to do such workarounds

kubapet commented 3 years ago

@FaramosCZ The answer regarding the application of the patches was ment to be for me when I was asking how to build that proton version manually. Noramlly if you run ubuntu/debian distro with latest glibc you probably don't have to do that. Just download the version of proton linked by @ga2mer (https://drive.google.com/file/d/1sV3LzfNBPKgCTMDa4Gg7E3lIMu6mybqf/view?usp=sharing) and put it under ~/.local/share/Steam/compatibilitytools.d/ (create that directory if it doesn't exist yet) and restart steam, then enforce the 5.17 version of proton to be used in the game properties and try to run it

FaramosCZ commented 3 years ago

Thanks, I created the compatibilitytools.d directory under the ~/.local/share/Steam/ path. I put the extracted archive there. I restarted Steam and then chosen the new version under "Force the use of a specific Steam Play compatibility tool"; selected "Proton 5.17.2.r9.gf90534f9"

The version of installed GLIBC packages is 2.31

The game still did not launched, unfortunatelly.

kubapet commented 3 years ago

try to check ~/steam-1030840.log and also I am not sure if it is not needed to extract the dist tar.gz inside of the archive.. I have done it.. and put it into compatibilitytools.d/Proton-5.17/dist

FaramosCZ commented 3 years ago

I examined the ~/steam-1030840.log. First of all, there was an error message that indicated it actually needs GLIBC 2.32. So I installed the appropriate version from Fedora Rawhide.

Then I got past the initiall error. I got roughly hundred of lines into the log then. I found a kinda hidden err message about missing /usr/bin/ntlm_auth, which I also fixed. (installed package samba-winbind-clients)

Now I have ~260 lines in the log and I don't see any more errors I would know how to fix.

Here are two logs. The first is after I renamed the mafiadefinitiveedition.exe to laucher.exe: https://www.pastebin.cz/raw/hjhVSAr

The second is with the original launcher, which show an unhandled exception at the end: https://www.pastebin.cz/raw/P1xFdim

k0d3r1s commented 3 years ago

hate that denuvo thing. trying and debugging this stuff and run into 24h activation block again :(
well, will continue tomorrow :(

kubapet commented 3 years ago

@FaramosCZ I think you can fix that exception by installing .NET 4.5.2 (there are some missing media player .net dlls probably) but you don't need to do that, if you fix it wou will most likely run into another issue related to performanceCounter.dll and it should be possible to launch the game directly without the launcher.

valters-tomsons commented 3 years ago

With help of @ga2mer's post - game runs pretty good with RX 590 and FX-8300.

Screenshots

![Screenshot_2020-09-27-08_1920x1080](https://user-images.githubusercontent.com/4209639/94363016-e24b2700-00c7-11eb-8165-b7bc64af8e20.png) ![Screenshot_2020-09-27-31_1920x1080](https://user-images.githubusercontent.com/4209639/94363012-d95a5580-00c7-11eb-99a5-5f0cf822edd1.png) ![Screenshot_2020-09-27-17_1920x1080](https://user-images.githubusercontent.com/4209639/94363014-dd867300-00c7-11eb-8500-d7c53bbf5388.png)

gytisrepecka commented 3 years ago

What were the steps to lauch the game successfully?

erikroe commented 3 years ago

Running on up-to-date Fedora 32, with glibc 2.32.9 from Fedora Rawhide repo, I followed all above steps. The game is starting for me without crashing, but it appears to be infinitely stuck on the inital loading screen. I run with Mesa 20.1.8 on an Radeon RX 5700. The CPU load on that initial loading screen is taking a bit more than one entire CPU core, without any progress after 5 minutes still.

ga2mer commented 3 years ago

@erikroe it's stuck on black screen/black screen with small game logo in top-left? If yes, create/edit videoconfig.cfg mentioned in my comment

erikroe commented 3 years ago

@ga2mer Thanks, I had written to the wrong file before. Now I went to the correct path you gave and it does work flawless. I do notice that apparently Fullscreen Mode in the game causes "freezing", so people should not activate it in-game.

erikroe commented 3 years ago

Little addition: On my system when the game runs in window mode it does not hide the taskbar of my desktop environment To fix this you can open a console WINEPREFIX=~/.steam/root/steamapps/compatdata/1030840/pfx/ winecfg and in the graphics options you enable Virtual Desktop.

kubapet commented 3 years ago

So I finally managed to compile my own Proton against my versions of glibc and other system libraries.. But I run into that shitty denuvo limit as well. I do not understand how do they dare to limit me how many times per day I want to reinstall my computer with the game.

k0d3r1s commented 3 years ago

@Stoobitweet do you have exact apt string for libc? i'm running debian, i don't really know ubuntus urls

k0d3r1s commented 3 years ago

@Stoobitweet i am aware of that one but that ubuntu package has a lot of dependencies :( so downloading only it isn't working. but maybe you can give ubuntu apt source link? if i use it only for libc, maybe it won't pull in too much ubuntu packages

FaramosCZ commented 3 years ago

I can confirm, the game works for me now ! ( yay \o/ ) What I saw yesterday was actually the Denuvo 24h ban. After that the game could be started.

I then ran into an issue with the screen size and resolution. The game started in FullHD resolution with window top left corner placed more or less in the middle of my (4K) screen.

The fullscreen mode can't be enabled (the game would became stuck if enabled), but here's a workaround I use:

1) Open the game int he window

2) Optional: Change resolution to your screen resolution (if not yet set)

3) ALT + F7 move the window to fill your whole screen (that was a shortcut to "move window" on my OS) at this point, you will have nearly fullscreen game - only top window bar and OS bottom menu line would be visible.

4) In the settings, enable borderless mode

And you have full screen game !

xDShot commented 3 years ago

And break everything else 👍

fsyy commented 3 years ago

here it doesn't run either with self compiled proton-tkg nor with proton-ge-6-st and added gamefix.

i'm on nvidia 450.56.11

here's my log from proton-ge-6-st:

https://gist.github.com/fsyy/68ea9654e29c3022b5932a5150da8cb6

kernle32dll commented 3 years ago

@GloriousEggroll

This should work with my latest stable (5.9-ge-6-st) build without any fiddling:

Proton-5.9-GE-6-ST/protonfixes/gamefixes/1030830.py

I suppose the filename should be 1030840.py (the ID of Mafia DE - *30 is Mafia 2 DE), and the script should be like this: (Note the different replace_command!)

""" Game fix for Mafia Definitive Edition
"""
#pylint: disable=C0103

from protonfixes import util

def main():
    """ Launcherfix and NVIDIA PhysX support.
    """

    # Fixes the startup process.
    util.replace_command('launcher.exe', 'mafiadefinitiveedition.exe')

Still, no dice. Here is the log - unfortunately I just hit the dreaded denuvo limit again, so it might not contain something useful (however, you can verify that the gamefix did work, by the correct cmd in the first lines of the log).

My distro is stuck on glibc 2.30, and I was unsuccessful in compiling my own proton due to 32bit lib shenanigans. So, still nothing here :(

fsyy commented 3 years ago

hmm.. i didn't check the steam id of the fix, anyways i tried renaming those files manually too, nothing changed

I suppose the filename should be 1030840.py (the ID of Mafia DE - *30 is Mafia 2 DE), and the script should be like this:

ghost commented 3 years ago

Thanks Paul for patches in game with similar issue, now it's running

Be careful, game has denuvo with 5 activation limit (means 5 unsuccessful launches) for 24 hours

* Open game folder (`~/.steam/root/steamapps/common/Mafia Definitive Edition`), rename `launcher.exe` to `something.exe` and `mafiadefinitiveedition.exe` to `launcher.exe`

* Download proton build - [link](https://drive.google.com/file/d/1sV3LzfNBPKgCTMDa4Gg7E3lIMu6mybqf/view?usp=sharing)

* Extract it to `~/.steam/root/compatibilitytools.d` (create if it doesn't exists), it should be folder like `~/.steam/root/compatibilitytools.d/proton_tkg_5.17.2.r9.gf90534f9` with scripts and proton_dist archive

* Restart steam, open properties of game, select custom proton and pick proton tkg 5.17 gf90534f9

* In same window open launch options

* Put this `PROTON_USE_SECCOMP=1 %command%`

* Now you can launch game for init config files, but fullscreen doesn't work and game just launch black screen/black screen with game logo in top-left, so for launch game you should make next item

* Create or open `~/.steam/root/steamapps/compatdata/1030840/pfx/drive_c/users/steamuser/My Documents/My Games/Mafia Definitive Edition/Saves/videoconfig.cfg` and edit to `-6 0 1920 1080 0 0 0 0 0` (1920 1080 is your resolution), same issue like Mafia 3

* Launch the game

Proton build may have issues with glibc, so before launch Mafia, try this build with other non-denuvo games Screenshot

Thanks @ga2mer for your post. Works perfectly fine on Ubuntu 20.10 (daily build).

GloriousEggroll commented 3 years ago

I suppose the filename should be 1030840.py (the ID of Mafia DE - *30 is Mafia 2 DE), and the script should be like this: (Note the different replace_command!)

""" Game fix for Mafia Definitive Edition
"""
#pylint: disable=C0103

from protonfixes import util

def main():
    """ Launcherfix and NVIDIA PhysX support.
    """

    # Fixes the startup process.
    util.replace_command('launcher.exe', 'mafiadefinitiveedition.exe')

My apologies, the fix I provided was for Mafia II DE. I somehow got them mixed up. I've removed my previous comment for now. If the game and launcher are in different directories like Mafia II's then my original syntax was correct.

willbeonekenobi commented 3 years ago

Hello,

I tried to launch the game by following the steps from @FaramosCZ . I'm on Ubuntu 20.04

To resume you need to :

  1. mkdir ~/.steam/steam/compatibilitytools.d/
  2. Download and uncompress the proton version in the folder created at step 1
  3. Install the glibc.6 lib from the "groovy" repositories (change in /etc/apt/sources.list focal to groovy) => apt install libc6
  4. Rename the launcher.exe to launcher_bak.exe and mafiadefinitiveedition.exe to launcher.exe
  5. Create the file described by @ga2mer
  6. Restart steam and select the new Proton version in the game
  7. Launch the game and it should work
  8. Reset the /etc/apt/souces.list to its normal settings

Hope it helps.

I have followed this up step by step. But sill no dice.

Sometimes I got a message saying an error has occurred.

k0d3r1s commented 3 years ago

@willbeonekenobi if you get an error with an url, that is denuvo's 24h limit :( for whatever reason it counts failed launches as different activations

GloriousEggroll commented 3 years ago

Alright, fixed it this time.

https://drive.google.com/file/d/1FlNrwG7YOBy5FQc1in6cyUwDDXSoPDGK/view?usp=sharing

Mafia DE and Mafia II DE should work ootb. Has Paul's patches and a protonfix that does all of the command changing, configurations for the screen on first launch, and necessary d3dcompiler override.

Also, for the love of god please stop informing people to update glibc on their systems. That can literally break the entire system.

mafiaintro mafia2 mafia3

kernle32dll commented 3 years ago

@GloriousEggroll works like a charm. Did a fresh install to be sure, fired up your build - bam!

And I didn't even need to update my Glibc :D

ghost commented 3 years ago

@GloriousEggroll GE strikes again, you're a beast man! Thank you very much.

Stoobitweet commented 3 years ago

@GloriousEggroll I installed your proton version, it works without any tweak ! Thank you for your work !

P.S : I deleted my posts where I updated glibc to avoid people from breaking their system. Sorry for this...

k0d3r1s commented 3 years ago

still not working on Debian 11. Did a fresh pfx, using this latest GE proton but no dice :( did see some splash screen for a split second but that's it.

my proton log, maybe someone could tell what is wrong here steam-1030840.log

RTheren commented 3 years ago

I had to reinstall whole game and restart Steam couple of times before it started to work (on Manjaro). I've played for an hour, until the game crashed. Thank you for this awesome Proton pack <3

kernle32dll commented 3 years ago

I've been playing a few hours with GE's Proton-5.9-GE-7-ST build (https://github.com/ValveSoftware/Proton/issues/4220#issuecomment-700255914). It also works surprisingly good speed wise - my rather dated AMD R9 390X is sufficient to play it on highest details on 1080p.

The only issue I encountered so far was that the game got once or twice stuck on cutscene to game transition (e.g. after the intro cutscene to the first gameplay segment). Stuck as in its only displaying the saving animation, music playing, but black screen otherwise. I was able to fix this by minimizing and maximizing the game (see here https://steamcommunity.com/app/1030840/discussions/0/2844543519798023476/).

Oh, and fullscreen is not working, same as Mafia 3. But hey - I do rather play the game windowed, than not at all <3

Jhackler commented 3 years ago

Runs great vega 56 aco :D

xStarxFox commented 3 years ago

works ootb ! Thanks a lot for your work ! (: cheers

Dinobeiser commented 3 years ago

dont know my issue - maybe can anyone help me.

i tried the new proton by GloriousEggroll

yesterday on my laptop in the evening with a fresh system it work ootb.

But today on my home computer (i reinstalled ubuntu 20.04)

i got the 24h bann.

Distro:Ubuntu 20.04.1 LTS Kernel:5.4.0-48-generic RAM:64 GB GPU Driver:NVIDIA 450.66 GPU:NVIDIA GeForce RTX 2080 Ti CPU:Intel Core i9-9900K @ 3.60GHz

After that i checked the lapotp but here, too a 24h denuvo bann.

I dont installed any other thing as i tried to start Mafia.

kubapet commented 3 years ago

I m still getting the following segfault:

https://pastebin.com/nX47M3zq

> which wine
/home/kubapet/.steam/steam/compatibilitytools.d/proton_tkg_5.18.r6.ge6345694/dist/bin/wine

..I had to build my own proton because I m running on glibc 2.31 :/

ga2mer commented 3 years ago

@kubapet you put PROTON_USE_SECCOMP=1 %command% in game launch options?

kubapet commented 3 years ago

@kubapet you put PROTON_USE_SECCOMP=1 %command% in game launch options?

I do

ga2mer commented 3 years ago

@kubapet if I read log correctly, you run game directly via wine without steam?

kubapet commented 3 years ago

well, yes I just wanted to see some output, but I run steam as well otherwise it complains that it is not running.. And if I run the game from Steam it just crashes and no log is produced, the play button just gets green again

kubapet commented 3 years ago

I just tried to switch to a factory repo of opensuse, I installed both 32bit and 64bit versions of glibc-2.32 (seems like it didn't break my system) and I tried to run Mafia using GloriousEggroll's Proton-5.9-GE-7-ST the standard way via steam but still no luck:

https://ulozto.net/file/isvWHi3xetpL/steam-1030840-log

ga2mer commented 3 years ago

@kubapet looks like you have issue with Vulkan initialize 15869.445:00d8:00dc:err:vulkan:wine_vkCreateInstance Failed to create instance, res=-6 and looks like it's VK_ERROR_LAYER_NOT_PRESENT error and tbh, I don't know how to fix that