Open NTMan opened 3 years ago
This is what the game needs and is missing from Wine
api-ms-win-core-kernel32-legacy-l1-1-2.dll:
VerifyVersionInfoA
api-ms-win-gaming-tcui-l1-1-0.dll:
ShowProfileCardUI
ShowPlayerPickerUI
ProcessPendingGameUI
Jup, same here, thought it would work after MS Flight Sim did but apparently there's something that need's more work.
I've written two patches:
https://source.winehq.org/patches/data/201351
I haven't yet tested the game. The gamingtcui patch is preliminary, based solely on the (mostly lacking) MSDN documentation. In other words, I don't expect this to work. But perhaps it'll shed some light on where to go next, or save those interested in debugging this from the boilerplate trouble.
Thank you for the patches. I've tried them and now the game crashes with Unimplemented function errors: KERNEL32.dll.GetSystemCpuSetInformation and KERNEL32.dll.SetThreadSelectedCpuSets
Hmm, from what I found, it seems that these functions are probably mostly used by UWP apps. Interesting, I thought that Forza Horizon 4 from Steam is no longer based on UWP.
Here are some bad stubs (I haven't written a patch, @jas0n098 did the test):
BOOL WINAPI GetSystemCpuSetInformation(void* information, ULONG buffer_length, PULONG returned_length, HANDLE process, ULONG flags)
{
if (!returned_length) return FALSE;
if (!information) {
*returned_length = 50; /* good enough? */
} else {
*returned_length = buffer_length;
memset(information, 0, buffer_length);
}
return TRUE;
}
void WINAPI SetThreadSelectedCpuSets(HANDLE thread, ULONG* cpu_set_ids, ULONG cpu_set_id_count)
{
}
Specfile entries should be something like:
@ stdcall GetSystemCpuSetInformation(ptr long ptr ptr long)
@ stdcall SetThreadSelectedCpuSets(ptr ptr long)
It appears to be crashing after though, for seemingly unrelated reasons: Edit: nevermind, this is not the right crash!
11038.547:0144:0148:Ret KERNEL32.K32GetModuleBaseNameA() retval=00000009 ret=143016517
11038.547:0144:0148:Call ucrtbase._stricmp(0022ebf0 "ntdll.dll",0022ec50 "ntdll.dll") ret=143016528
11038.547:0144:0148:Ret ucrtbase._stricmp() retval=00000000 ret=143016528
11038.547:0144:0148:trace:seh:dispatch_exception code=c0000005 flags=0 addr=0000000000000000 ip=0000000000000000 tid=0148
11038.547:0144:0148:trace:seh:dispatch_exception info[0]=0000000000000008
11038.547:0144:0148:trace:seh:dispatch_exception info[1]=0000000000000000
This is called from a TLS callback (144BAC930) in ForzaHorizon4.exe , and it appears to iterate over loaded modules, trying to find ntdll.dll (\~60,000 lines of K32GetModuleBaseNameA
), where it subsequently crashes on trying to run a null address. Apparently this game has pretty heavy anti-hooking/cheating code, so this might be an intentional crash?
Alright, the actual crash seems to be here:
11064.402:0144:015c:trace:module:load_dll Loaded module L"\\??\\C:\\windows\\system32\\rsaenh.dll" at 000000006FC40000
...
11064.405:0144:015c:trace:module:process_attach (L"rsaenh.dll",0000000000000000) - START
11064.405:0144:015c:Call LDR notification callback (proc=0000000143010560,reason=1,data=000000000BC9CD90,context=0000000000000000)
...
11064.832:0144:015c:Ret KERNEL32.K32GetModuleBaseNameA() retval=0000000e ret=143010888
11064.832:0144:015c:Call ucrtbase._stricmp(0bc9c2b8 "kernelbase.dll",0bc9c8a0 "kernelbase.dll") ret=14301089c
11064.832:0144:015c:Ret ucrtbase._stricmp() retval=00000000 ret=14301089c
11064.832:0144:015c:trace:seh:dispatch_exception code=c0000005 flags=0 addr=0000000000000000 ip=0000000000000000 tid=015c
...
11064.832:0144:015c:trace:seh:dump_unwind_info unwind info at 0000000146EB1B20 flags 2 prolog 0x3d bytes function 0000000143010560-000000014301206F
(I'm keeping the earlier crash because of the similarity to this crash)
This seems to me like some kind of anti-hooking code:
11037.569:0144:0148:Call ntdll.LdrRegisterDllNotification(00000000,143010560,00000000,0022ede8) ret=1430123bc
Right after this crash, it'll run:
11064.832:0144:015c:Call ucrtbase._wfopen(7f0aebc40580 L"C:\\users\\...\\Local Settings\\Application Data\\ForzaHorizon4\\scratch\\CrashReport.xml",1450430a8 L"w") ret=14335d1bd
A quick look at the file doesn't appear to show much useful information (at least nothing that isn't already present in the log)
I think this is as far as I can figure out, I'll leave this to the geniuses at wine :)
(Big thanks to @jas0n098 for trying patches and sending the logs)
Apparently this gets it to boot:
diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c
index a7e6d712df1..4e2dc538862 100644
--- a/dlls/ntdll/loader.c
+++ b/dlls/ntdll/loader.c
@@ -1581,6 +1581,8 @@ NTSTATUS WINAPI LdrRegisterDllNotification(ULONG flags, PLDR_DLL_NOTIFICATION_FU
TRACE( "(%x, %p, %p, %p)\n", flags, callback, context, cookie );
+ return STATUS_SUCCESS;
+
if (!callback || !cookie)
return STATUS_INVALID_PARAMETER;
Looks good enough to upstream? :stuck_out_tongue_winking_eye:
So it's almost certainly some kind of anti-hooking code then.
Trying to patch out more (e.g. if the callback is 0x62166B50
in TpAllocWork
, set it to a fake callback instead) does advance further, but I don't think this is going to work properly. There are numerous checks littered through the game, including within work threads that also handle game code.
I think all the issues preventing the game start are clear now, while it might take a bit of time for cleaning up the patches and debugging what goes after the game start . @qsniyg since you've done some debugging and might be curious what it wants at this point I can share our findings if you contact me on IRC or e-mail privately.
Any new progress? :-)
Vkd3d-proton work is needed to go further, and is ongoing. Please be patient :wink:
How can i use these patches ? Can somebody please explain
How can i use these patches ? Can somebody please explain
@edd-dev It doesn't work yet, so there's no point really...
My forza is giving error when trying to open this Dll is missing:
can anybody help me?
My forza is giving error when trying to open this Dll is missing:
can anybody help me?
what dlls are missing? You haven't given any.
My forza is giving error when trying to open this Dll is missing: can anybody help me?
what dlls are missing? You haven't given any.
007c:err:hid:parse_descriptor Unknown (bTag: 0x0, bType: 0x0) 00c8:err:module:import_dll Library api-ms-win-gaming-tcui-l1-1-0.dll (which is needed by L"Z:\ForzaHorizon4.exe") not found 00c8:err:module:import_dll Library api-ms-win-core-memory-l1-1-3.dll (which is needed by L"Z:\ForzaHorizon4.exe") not found 00c8:err:module:import_dll Library api-ms-win-core-kernel32-legacy-l1-1-2.dll (which is needed by L"Z:\ForzaHorizon4.exe") not found 00c8:err:module:LdrInitializeThunk Importing dlls for L"Z:\ForzaHorizon4.exe" failed, status c0000135
Sorry dll: api-ms-win-gaming-tcui-l1-1-0.dll
This is what the game needs and is missing from Wine
api-ms-win-core-kernel32-legacy-l1-1-2.dll: VerifyVersionInfoA api-ms-win-gaming-tcui-l1-1-0.dll: ShowProfileCardUI ShowPlayerPickerUI ProcessPendingGameUI
noob question here maybe, but how did you find out the wine dlls that are required for this app to function?
Those aren't the only issues to fix for the game to run though.
This is what the game needs and is missing from Wine
api-ms-win-core-kernel32-legacy-l1-1-2.dll: VerifyVersionInfoA api-ms-win-gaming-tcui-l1-1-0.dll: ShowProfileCardUI ShowPlayerPickerUI ProcessPendingGameUI
noob question here maybe, but how did you find out the wine dlls that are required for this app to function?
@netizener Looking at the log after attempting to run the game...
@Tk-Glitch Those aren't the only issues to fix for the game to run though.
What (do we know of so far) needs to be implemented for FH4 to run?
Sorry dll: api-ms-win-gaming-tcui-l1-1-0.dll
same :< where i can DL that DLL?
Sorry dll: api-ms-win-gaming-tcui-l1-1-0.dll
same :< where i can DL that DLL?
@paulopogi01 afaik it needs to be implemented in Wine...
@CCF100 It's not only functions to implement. The game has special needs on both wine and vkd3d-proton fronts, and they are being addressed. The last bit can be found here if you're curious: https://github.com/HansKristian-Work/vkd3d-proton/pull/621
Forza Horizon 4 should now be playable with latest Proton Experimental on AMD GPU with mesa-git. :-)
What's the problem with NVIDIA?
So this game doesn't run with NVIDIA?
Forza Horizon 4 should now be playable with latest Proton Experimental on AMD GPU with mesa-git. :-)
As far as I understand this is a UWP game, is there a chance that with the new version proton and other uwp games will start?
Game does start with latest Proton Experimental, but crashes during the first race. BTW its NVIDIA GPU
Same here, Game works perfectly fine just driving around running on Nvidia GPU, but also crashes on the first race. Also doesn't launch again, after the crash, it throws a page fault exception:
Unhandled exception: page fault on write access to 0x00000000 in 64-bit code (0x00000001432fe38c).
Also noticed, while at it, controller doesnt seem to work in the welcome menu, but works fine afterwards.
Forza Horizon 4 should now be playable with latest Proton Experimental on AMD GPU with mesa-git. :-)
@rejedai As far as I understand this is a UWP game, is there a chance that with the new version proton and other uwp games will start?
Forza Horizon 4 is a special case, while it is a UWP game, it was (mostly) ported to Win32 so that it could be released on steam. It still uses some UWP functions, however. (This is all based off of my understanding, so things could be wrong, lol)
Same here, Game works perfectly fine just driving around running on Nvidia GPU, but also crashes on the first race. Also doesn't launch again, after the crash, it throws a page fault exception:
Unhandled exception: page fault on write access to 0x00000000 in 64-bit code (0x00000001432fe38c).
Also noticed, while at it, controller doesnt seem to work in the welcome menu, but works fine afterwards.
@jannis3005 What driver version are you using? The game doesn't even start for me...
Same here, Game works perfectly fine just driving around running on Nvidia GPU, but also crashes on the first race. Also doesn't launch again, after the crash, it throws a page fault exception: Unhandled exception: page fault on write access to 0x00000000 in 64-bit code (0x00000001432fe38c). Also noticed, while at it, controller doesnt seem to work in the welcome menu, but works fine afterwards.
@jannis3005 What driver version are you using? The game doesn't even start for me...
@CCF100 you mean the nvidia driver? 465.24.02
Same here, Game works perfectly fine just driving around running on Nvidia GPU, but also crashes on the first race. Also doesn't launch again, after the crash, it throws a page fault exception:
Unhandled exception: page fault on write access to 0x00000000 in 64-bit code (0x00000001432fe38c).
In the present case, that is an explicit assertion in the game code which it usually fires when gets an expected error from d3d subsystem. I think if you look at 'dmesg' command output you will likely find GPU memory faults.
Same here, Game works perfectly fine just driving around running on Nvidia GPU, but also crashes on the first race. Also doesn't launch again, after the crash, it throws a page fault exception:
Unhandled exception: page fault on write access to 0x00000000 in 64-bit code (0x00000001432fe38c).
Also noticed, while at it, controller doesnt seem to work in the welcome menu, but works fine afterwards.
Same here. I even tried with the latest Vulkan beta driver. Someone have to tell NVIDIA for this bug.
weird. it seems to sometimes work and sometimes not work. I was able to play the story and even do a face. but the Next time i Start the Game, it crashes while loading
Forza Horizon 4 should now be playable with latest Proton Experimental on AMD GPU with mesa-git. :-)
@AsciiWolf
As you can see the game can only show splash screen on my system.
Try this: steam_dxvk_forza.txt
rename it .conf and add it as dxvk config file in steam launch options. with that I have it almost working without issues on nvidia. EDIT: Updated the config. Hint: if the game stutters weirdly, enable vsync and cap your framerate, that may help.
Try this: steam_dxvk_forza.txt
rename it .conf and add it as dxvk config file in steam launch options. with that I have it almost working without issues on nvidia. EDIT: Updated the config. Hint: if the game stutters weirdly, enable vsync and cap your framerate, that may help.
With this config, the game doesn't crash on you? How long were you able to run?
Try this: steam_dxvk_forza.txt rename it .conf and add it as dxvk config file in steam launch options. with that I have it almost working without issues on nvidia. EDIT: Updated the config. Hint: if the game stutters weirdly, enable vsync and cap your framerate, that may help.
With this config, the game doesn't crash on you? How long were you able to run?
I played for about an hour and I had one crash, but I also sometimes have crashes when playing the game on windows on the same PC, so I don't think that crash was proton related
Replying to https://github.com/ValveSoftware/Proton/issues/4667#issuecomment-825915355
That sounds great, but I had refunded the game before I could try this since I don't have a windows machine to play this game. Hoping someday it becomes playable ...
Replying to https://github.com/ValveSoftware/Proton/issues/4667#issuecomment-825738356
I think I have the same problem with the game being stuck in the splash screen.
Hello @gabibbo97, the changelog note for Proton Experimental mentions that a bleeding edge mesa build is needed, and your log mentions that there are missing video driver features, which hints that something on your system is too old for VKD3D 2.3. Most likely mesa/radv, small chance that the kernel is too old.
glxinfo says
OpenGL renderer string: AMD Radeon R9 200 Series (HAWAII, DRM 3.40.0, 5.11.16-300.fc34.x86_64, LLVM 13.0.0) OpenGL core profile version string: 4.6 (Core Profile) Mesa 21.2.0-devel
Mesa version is built from a12b844 commit. I'll retry with version 7e905bd0 (latest master) and update my report
On Sat, 24 Apr 2021, 15:04 kisak-valve, @.***> wrote:
Hello @gabibbo97 https://github.com/gabibbo97, the changelog note for Proton Experimental mentions that a bleeding edge mesa build is needed, and your log mentions that there are missing video driver features, which hints that something on your system is too old for VKD3D 2.3. Most likely mesa/radv, small chance that the kernel is too old.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ValveSoftware/Proton/issues/4667#issuecomment-826089923, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA35XFQ4GN2YCP7DA4MY2R3TKK6UVANCNFSM4Y4KJRGQ .
I wouldn't be surprised if VKD3D-Proton has a harder time running on pre-Polaris / GCN4 AMD cards and the Hawaii chipset is a Sea Islands / GCN2 card.
Yup, does not work even with the latest Mesa, guess I'll be in the market for GPUs, thanks anyway
On my desktop, I can pretty much 99.5% of the time get Forza to crash my GPU by attempting to enter a race.
Forza Horizon 4 should now be playable with latest Proton Experimental on AMD GPU with mesa-git. :-)
@AsciiWolf
I has mesa from git and latest Proton Experimental 6.3-20210423 and I launch Forza Horizon 4 20 minutes later...
As you can see the game can only show splash screen on my system.
Yep, I'm having the same issue. RX5700XT on Fedora, using che's mesa git. But then again, maybe my mesa driver isn't the newest (it has been updated yesterday though, and AFAIK it is the master branch).
Forza Horizon 4 should now be playable with [latest](https://github.com/ValveSoftware/Proton/wiki/Changelog#available-in-> Yep, I'm having the same issue. RX5700XT on Fedora, using che's mesa git. But then again, maybe my mesa driver isn't the newest (it has been updated yesterday though, and AFAIK it is the master branch).
276:err:vkd3d_init_device_caps: Timeline semaphores are not supported by this implementation. This is required for correct operation.
That's weird, something probably went wrong with host Mesa setup.
@gabibbo97 and @NicoSoler, please copy your system information from Steam (Steam
-> Help
-> System Information
) and put it in a gist, then include a link to the gist in this issue report. Hopefully we can find a pattern that hints as to why there's missing driver features.
Working very well on Nvidia here, though I had to upgrade from 460.x to 465.24.02 (and use dxgi.customVendorId = 10de
) to prevent a crash in the second stage of the first race.
Did anyone manage to get a wheel controller to work? My G29 is not detected, not even as a generic input device.
According to game's inputmappingprofiles.zip
it should be looking for VID/PID 0x046dc24f
which matches with how my controller presents itself.
The game manual warns that Logitech gaming software is necessary for correct controller detection, but it also explains that is purely to ensure the controller uses the right VID/PID, so that shouldn't be an issue under Proton.
Any ideas what else might the game expect from the controller to recognize it?
Here's +hid,+hidp,+hid_report,+rawinput,+xinput,+dinput,+plugplay,+joystick,+winmm
:
trace.txt
In particular, the trace suggests the device is available to wine:
0234:trace:dinput:find_sdldevs Found a joystick on 0x7efbf8080900: Logitech G29 Driving Force Racing Wheel
0234:trace:dinput:find_sdldevs ... with force feedback
0234:trace:dinput:find_sdldevs Found a joystick on 0x7efbf801c080: Xbox 360 Controller
0234:warn:dinput:find_sdldevs Ignoring force feedback support for "Xbox 360 Controller"
0234:trace:dinput:fill_joystick_dideviceinstanceA 580 0x1dfff420
0234:trace:dinput:fill_joystick_dideviceinstanceW 1100 0x1dfff700
Compatibility Report
System Information
I confirm:
steam-1293830.log
Symptoms
The game crashes at start.
Reproduction
Always.
UPDATE with Proton experimental-6.3-20210723b
The following problems still remain unresolved:
At startup and when changing graphics settings, the game shows a black screen. To show the picture from the game, you need to press <Alt + Tab> twice to switch to a any other window and return back to the game. The bug is repeated with both RADV and AMDVLK. Demonstration: https://youtu.be/GSOvB-LeUkA
~~During first race in Fortune Island event the game crashes every time. Demonstration: https://youtu.be/k73nyalMLPs Proton log: https://drive.google.com/file/d/1bRO5nTtGyM6TEhxyFOjTbIoxcT8DLHMq/view?usp=sharing (105.1 MB)~~ UPD: Fortune Island event is playable with Proton experimental-6.3-20211004
Unable to add a friend to the session. The game says that there are no friends online. Game Bar is also not called by <Super + G>.![Screenshot from 2021-07-24 16-33-31](https://user-images.githubusercontent.com/200750/126869508-c22a15f7-face-4a34-8ad5-5bfafeae0660.png)
When trying to find a club, the game shows the error "There is no Windows program configured to open this type of file."
After clicking on the "Ok" button, the screen goes out, and to return the picture you need apply workaround solution from issue 1, after which we see another error "There was an error communicating the Forza Horizon 4 server. Please try again later."
![Screenshot from 2021-07-24 16-42-23](https://user-images.githubusercontent.com/200750/126869523-084e0fbf-c55d-4c49-8a99-2504650cc7f0.png)
PROTON_LOG = 1 is too verbosive, which makes it impossible to use it. If it's just stupid to go in and exit the game without playing for a second, then 500Mb of logs will be written to the disk. And for an hour of the game, 100Gb of logs are accumulated. The logs are flooded with messages
trace: seh: dump_unwind_info
with assembler opcodes. And FPS with PROTON_LOG = 1 sags at least three times. steam-1293830.zipVibration of triggers does not work on Microsoft gamepads imitating traction, thus killing the wow effect that I got playing for the first time in Forza Horizon 4 on Xbox One X.