search

ValveSoftware / Proton

Compatibility tool for Steam Play based on Wine and additional components
Other
24.19k stars 1.06k forks source link

Proton 7.0-3 Release Candidate testing #5881

Closed ivyl closed 2 years ago

ivyl commented 2 years ago

Hey all. We've put together a new 7.0 Release Candidate build for you to test.

In the Steam client, the Proton 7.0 app should have a release-candidate beta branch (look for Proton 7.0 in your Steam Library, right click -> Properties... -> BETAS) which you can choose to start testing the 7.0-3 Release Candidates (note that the name of the build in the Steam Settings dialog will not be updated). I will post changes here when we push new builds. The source for the latest RC build is available on the proton_7.0-rc branch in this repository. This branch may be force pushed.

We are interested only in issues that are new to the 7.0-3 RC builds. If you believe that something broke please confirm that the problem does not occur with the "none" branch before reporting it here.

The changelog is tentative - it has not yet been verified by our QA staff, and can change before the final release as we add or remove features during RC testing.

d10sfan commented 2 years ago

Planetary Annihilation: TITANS for me has the menus working now, where previously they would flicker and be impossible to load in. Now when I try and create a match, the UI to pick a spawn point never appears. I can see the in-game menu flicker for half a second and then disappear. Then a black box appears in the right side of the screen.

Since it's in the playable list for this RC, wanted to report my experience.

ivyl commented 2 years ago

@d10sfan indeed some things were fixed but the game is still not "playable". I've removed it from the list. Thanks for the report!

sxiii commented 2 years ago

Final Days, report as works on Proton 7.0rc2-GE-1. Training completed at least, no issues :) UPD: Multiplayer checked as well and working OK.

Photon89 commented 2 years ago

Proton 7 is broken for Assetto Corsa, it fails to load a race and falls back to the menu UI. It has still worked in Proton GE 6.13.

edit: Never mind, I guess, I should report it against Proton GE. Sorry! :smiley:

deathxxx123 commented 2 years ago

You are great guys! 

Improve Sekiro: Shadow Die Twice performance in certain areas.
Fix Elden Ring crashing during prolonged gameplay.
ranplayer commented 2 years ago

I've found out a regression with this RC. Bionic Commando hangs on a black screen after launch.

steam-21670-proton70-3.tar.gz

alasky17 commented 2 years ago

@ranplayer This doesn't appear to be a regression. In our testing, the game sometimes crashes on launch on 7.0-2 and also often works correctly on 7.0-3. Please let me know if you see a consistent failure to launch on -3 vs consistent good behavior on -2.

ranplayer commented 2 years ago

@alasky17 I've just removed the old prefix and tried 5 times in a row: same result. I haven't experienced any crash with 7.0-2 after playing for some time.

Test specs:

Let me know if more information is required

Blisto91 commented 2 years ago

I did some testing on my nvidia setup which is very similar to yours

At first i didn't reproduce it, but then i messed with some stuff and rebooted and then i could reproduce it (black screen on each launch) Messed with some more stuff and then i couldn't again. Not sure what or why yet.

ranplayer commented 2 years ago

@Blisto91 I've tried changing the DXVK's version to the previous one, but it didn't help. I've tried a couple of other D3D9 games, but they are working fine with this RC. The only lines of interest I've noticed on the crash logs are:

5286.748:0120:0134:fixme:oleacc:find_class_data unhandled window class: L"#32769"
warn:  D3D9DeviceEx::SetRenderState: Unhandled render state D3DRS_ADAPTIVETESS_W
AL lib: (EE) alc_cleanup: 1 device not closed
parkerlreed commented 2 years ago

Can confirm Postal4 running great with the video fixes

ivyl commented 2 years ago

Proton 7.0-3 has been released. Thank you all for your reports. Closing the issue.

@ranplayer we can shift the discussion about Bionic Commando to bug #1426. I don't believe it's a regression, but something that makes pre-existing issue much more likely for you to hit. Our QA was able to get inconsistent crashes with both 7.0-2 and 7.0-3. I was unable to hit it even a single time on any of my development systems (mixture of Intel/AMD and Nvidia/Radeons), even when defaulting to esync.

Arthus commented 2 years ago

@ivyl Please excuse me but I'm curious: How did you improve the performance in Sekiro? I compared 7.0-2 and 7.0-3 and didn't find a commit explicitly mentioning that game. Can you point me to the right commit/code?

alasky17 commented 2 years ago

@Arthus I can answer this one :) There was a specific perf issue with Sekiro: Shadows Die Twice that was causing stutter/fps drops when transitioning between different areas. There were several changes to ntdll that were upstreamed in wine and included in this release to fix the issue: ntdll: Implement CPU topology override, ntdll: Collect logical processor info at process start, ntdll: Refactor logical processor info manipulation functions, ntdll: Move init_cpu_info() below create_logical_proc_info(), ntdll: Fix allocation size in grow_logical_proc_ex_buf() I don't have the upstream wine hashes on hand, but hopefully you can use the commit names to find them :)

Arthus commented 2 years ago

@alasky17 I found the MR with some of the changes: https://gitlab.winehq.org/wine/wine/-/merge_requests/32 Thank you very much :) ("ntdll: Implement CPU topology override" is not included in that MR but my question has still been answered.)

ivyl commented 2 years ago

The topology override was reverted as it interfered with the changes and then "reimplemented" on top of them. It was cleaner to do this way than to adapt the upstream patches to Proton customization. Topology override shouldn't matter for Sekiro.