ValveSoftware / Proton

Compatibility tool for Steam Play based on Wine and additional components
Other
24.26k stars 1.06k forks source link

Proton 8.0-3 Release Candidate Testing #6834

Closed ivyl closed 1 year ago

ivyl commented 1 year ago

Hey all.

We've put together a new 8.0 Release Candidate build for you to test.

In the Steam client the Proton 8.0 app should have a release-candidate beta branch (look for Proton 8.0 in your Steam Library, right click -> Properties... -> BETAS) which you can choose to start testing the 8.0-3 Release Candidates (note that the name of the build in the Steam Settings dialog will not be updated). I will post changes here when we push new builds. The source for the latest RC build is available on the proton_8.0-rc branch in this repository. This branch may be force pushed.

We are interested only in issues that are new to the 8.0-3 RC builds. If you believe that something broke please confirm that the problem does not occur with the none branch before reporting it here.

The changelog is tentative - it has not yet been verified by our QA staff, and can change before the final release as we add or remove features during RC testing.

ranplayer commented 1 year ago

Hi there,

I've found a regression with this RC related to FSYNC in Lara Croft and The Temple of Osiris: stuttering and weird frame timing. In the Southern Cliffs level the stuttering is so hard that makes the game unplayable. If you disable FSYNC (PROTON_NO_FSYNC), the game works normally. This issue is not happening with Proton 8.0-2.

Log file: steam-289690.tar.gz

Specs: OS: Arch Kernel: 6.1.35 GPU: RX 6700 XT (Mesa 23.1.2) CPU: Ryzen 7 5700 G Display server: X11

Game specs:

alasky17 commented 1 year ago

@ranplayer Thank you for reporting this! Would you mind uploading a save file for the Southern Cliffs level so that it is easier for us to investigate this?

Could you also get a log with PROTON_LOG=+fsync %command%?

ranplayer commented 1 year ago

Hi @alasky17 , I can upload the save and get the new logs next week (I'm not at home these days). I believe you are able to see the stuttering and weird frame timing also in the open map.

alasky17 commented 1 year ago

@ranplayer Unfortunately I've been unable to reproduce any stuttering with the map -- I'm assuming you just meant the static map that you can open in the menu, next to the adventure log etc?

When you are able to retest - could you also please try experimental-8.0 to see if the issue persists there?

Also - were you using any program in particular to investigate the frame timing? I tried using mangohud and for some reason the overlay didn't show up for this game.

ranplayer commented 1 year ago

@alasky17 I meant the main open area where you can enter the levels (sorry for the wrong terminology). I've been using mangohud to check the frame timing, but I had the same issue as you. To solve it I had to recompile the mangohud package (I've been using the AUR's). When I get back home I'll test the latest experimental as well.

alasky17 commented 1 year ago

@ranplayer Unfortunately I am not familiar with this game and so I'm not sure how to get to that open area. I got past the first tutorial area, hoping that I would get into the open area after that, but it just took me to the next part of the map which seems to be called "shrine of osiris"(?) with no open area that sounds like what you described. I guess maybe I'll just have to wait for you to get back to get a save file :)

simifor commented 1 year ago

I can reproduce the tomb raider issue, it actually appears since the gameplay starts so it takes no time to verify it. With 8.0-3 the game has constant stutters, with 8.0-2 it's locked to 60 fps. Lara Croft and the Temple of Osiris 2023-06-29_18:54:21 steam-289690.zip here is the log with PROTON_LOG=+fsync %command% My specs like ranplayer, I have a zen 3 cpu (5600G)

Edit: Also tested proton 7 and GE proton 8-4. The problem isn't present in proton 7 but it is present in GE proton as well

alasky17 commented 1 year ago

@simifor @ranplayer Good news - I was finally able to repro locally with another machine. We are on the case and hoping to fix this for the final 8.0-3 build. Thank you for testing the release candidate and reporting here :)

alasky17 commented 1 year ago

@simifor @ranplayer This should be fixed in experimental-bleeding-edge. If you have time to test and help confirm since this seems fairly hardware specific, that would be greatly appreciated :)

ranplayer commented 1 year ago

@alasky17 I've tested it against the latest experimental bleeding edge and it's working fine now. Thank you for digging into this issue (:

simifor commented 1 year ago

Experimental is working better than 8.0-3, but still worse than older versions @alasky17

Experimental Lara Croft and the Temple of Osiris 2023-07-04_18:10:54

8.0-3 Lara Croft and the Temple of Osiris 2023-07-04_18:14:07

7.0-6 Lara Croft and the Temple of Osiris 2023-07-04_18:23:42

alasky17 commented 1 year ago

@simifor I tried comparing 7.0-6, 8.0-2 and experimental-bleeding-edge, and they all behaved very similarly to me. I noticed that the very first time I went to a new area, there would be more blips in the mangohud frametime tracker, but I did not see a significant difference when I compared the same area and kept flipping back and forth between builds. I am hoping that the difference you saw was only because you tested experimental first.

8.0-2 vs experimental-bleeding-edge is a better point of comparison because 7.0-6 is quite different. If you are still seeing a difference between 8.0-2 and experimental-bleeding-edge, could you try disabling fsync on experimental to confirm if what you are seeing is still a fsync regression?

ranplayer commented 1 year ago

@simifor you have to change the Experimental branch to "bleeding edge" (via Properties -> Betas -> Beta Participation)

VladimirMrzv commented 1 year ago

In games with Original/EA client not working steam overlay. Only showing from Original/EA, and when got achievement it take focus on it and not in game. Tested on Proton 7 / 8 / Experimental

kisak-valve commented 1 year ago

Hello @VladimirMrzv, that's a preexisting issue being tracked at #4009. It's not relevant here because this issue report is specifically for catching any new issues between Proton 8.0-2 and the 8.0-3 release candidate.

simifor commented 1 year ago

@ranplayer yeah, I was already on bleeding edge. @alasky17 I don't see the same continuous spike, but moving around the map and during the cutscene (which had already played in a previous session), but there are still some weird spikes on Be even after reentering the same area Lara Croft and the Temple of Osiris 2023-07-05_16:37:53 Lara Croft and the Temple of Osiris 2023-07-05_16:40:00

on 8.0-2 there was only a single spike the moment the cutscene stared, but no spikes throughout or when moving around Lara Croft and the Temple of Osiris 2023-07-05_16:49:48

BE with FSYNC disabled behaves like 8.0-2, no weird spikes while moving around Lara Croft and the Temple of Osiris 2023-07-05_16:55:09


I need to specify the BE screenshots were "cherrypicked", those spikes weren't constant, but they could trigger while moving around the map (less often after they triggered once in a certain part of the map, but they didn't happen at all with 8.0-2 and with FSYNC disabled)

alasky17 commented 1 year ago

@simifor I am still not seeing the spikes as I keep playing through the game. There are a couple of things that could potentially help us investigate this, but I understand if the asks are too big: 1) Could you try using the stock kernel instead of tkg to eliminate a potential factor? 2) Could you confirm if the spikes still happen in the tutorial? I think this might wipe your progress though, and I've had no luck with transferring saves, so be aware if you do this, a backup save file might not work :(

simifor commented 1 year ago

@alasky17 didn't retest tutorial area but I don't see the spikes anymore when using stock 6.4.1

alasky17 commented 1 year ago

@simifor Thank you for checking that! Greatly appreciated to help solve the mystery :)

ZeroYamaoka commented 1 year ago

Well nice that DJ Max Respect is playable but did ustable frame rate isuee gonna be fixed ? https://youtu.be/rtX2S6v3kiw here is example of problem and its on new 8.0-3

ivyl commented 1 year ago

There's work on the DJ Max Respect happening in upstream. It was shortly in experimental but had to be reverted due to regressions it caused in other places. We'll bring it back once it's all sorted out.

ivyl commented 1 year ago

Closing since 8.0-3 was just released. Please report problems with any games in their respective issue threads. Thanks!