ValveSoftware / Proton

Compatibility tool for Steam Play based on Wine and additional components
Other
23.35k stars 1.02k forks source link

Deus Ex: Game of the Year Edition (6910) #798

Open Ruedii opened 5 years ago

Ruedii commented 5 years ago

Deus Ex: Game of the Year edition works perfectly with the shipping D3D Render path. As far as I can tell there are no noticeable bugs, and performance is exceptional.

The shipping GL Render path is a little buggy, but it is buggy on many Windows systems as well.

kisak-valve commented 3 years ago

Hello @shoober420, while it's okay to discuss game modifications and workarounds in general (as long as they are legal), we're primarily interested in feedback on how vanilla Proton behaves with the version of game available on Steam. @Wedge009's choice to use the game unmodified is completely legitimate feedback for the game.

You're free to point out that there are alternative solutions available for people to try, but feedback on the current out of the box experience is more valuable when it comes to improving Proton.

shoober420 commented 3 years ago

You saying you want to focus on goty, but already bringing Revision into the picture, a third party community patch, is contradictory, which is why i mentioned third party mods for goty to begin with.

some windows games have bugs that are native, and then reproduced in proton as well, and then get posted here as being proton bugs, when it’s a bug in windows too. i remember the stalker shadow or chernobyl lighting bug that some thought was proton, but is a bug in the original game.

it was just a way to narrow things down and do testing. if you’re testing revision, which uses third party mods, there’s no reason to be so against deus ex goty with mods, even if it is working for you. it was only for testing purposes.

adding mods to a game doesn’t derail anything, if that was the case, revision would derail then too.

i’m not forcing you to do anything, it’s all for testing the game. all i’m doing is offering recommendations and things to try, there’s no need to be upset over them.

i have been respectful and even apologized for assuming you were a new user. you’re the only one name calling here and being hard to work with.

shoober420 commented 2 years ago

Compatibility Report

System Information

These tests were done with the CWDohnal OpenGL renderer. https://www.cwdohnal.com/utglr/

Symptoms

Proton GE: Brightness slider doesnt work, but the brightness is more natural looking. 20210710_12h34m57s_grim

Proton Experimental: Brightness slider works, but brightness is too washed out. 20210710_12h28m30s_grim

Trying to change the brightness via the DeusEx.ini also doesnt work.

EDIT: I've continued doing testing for Revision on the dedicated Proton Github page. https://github.com/ValveSoftware/Proton/issues/4958

shoober420 commented 2 years ago

Was playing around with Revision and wondered if the new Revision Direct3D 9, OpenGL, and OpenAL renderers would work with the vanilla GotY, and they indeed do work. The new OpenAL sound renderer is fantastic. The audio quality is noticeably better compared to the original Galaxy audio render. It also seems to make the players mouths move faster, and more in sync compared to the original Galaxy audio renderer.

Also, if you want the new OpenAL audio renderer work with GotY, you need to copy over all the dll files that start with “lib” in the “Revision/System”, along with msvcr*.dlls, ALAudio and ALURE32 dlls, and the OpenAL32.dll files.

shoober420 commented 2 years ago

Here are some screenshots of the brightness using the Revision D3D9 render on Deus Ex GotY. The brightness slider works on both Proton versions, no washed out textures on either version as well.

GE Log: steam-6910ge.log Experimental Log: steam-6910ex.log

GE 6.12-1: 20210713_20h03m54s_grim

Experimental: 20210713_20h08m21s_grim

AsciiWolf commented 2 years ago

Deus Ex: GotY with Proton 6.3-5, running on Fedora 34 (with Wayland) with Mesa 21.1.4 (using Radeon RX 550 4G). Ingame colors look strange:

deus-ex_colors

(I have 32-bit color depth enabled in the game display settings.)

Did anyone experience similar issues?

shoober420 commented 2 years ago

@AsciiWolf Yes, I did, along with @zolstarym is his post here from above.

https://github.com/ValveSoftware/Proton/issues/798#issuecomment-861041146

Wedge009 commented 2 years ago

Proton GE: Brightness slider doesnt work, but the brightness is more natural looking.

So in the context of the visual issues, this doesn't appear any different from Proton 5.13.

Proton Experimental: Brightness slider works, but brightness is too washed out.

This is what I was asking for earlier. Again, no apparent differences from Proton 6.3. So in both cases, no improvement with this 'CWDohnal' renderer.

The audio quality is noticeably better compared to the original Galaxy audio render.

If anything, audio is even more subjective than visuals. Other than lip-sync, is there any measurable improvement from a player's point of view? This might be a distraction from the core visual issues here - unless any perceived shortcoming of audio is not present in Windows, only under Proton.

Here are some screenshots of the brightness using the Revision D3D9 render on Deus Ex GotY. The brightness slider works on both Proton versions, no washed out textures on either version as well.

Interesting. But Revision's D3D9 renderer is broken for me under Proton so unfortunately I can't make use of this.

Edit: Previous tests were on Proton 6.3-4. Retesting on Proton 6.3-5 Revision's D3D9 renderer no longer crashes, but interestingly visuals now exhibit the same behaviour as on Proton 5.13 - ie good colour reproduction but non-working brightness adjustment. Which is a shame because if I got the same behaviour as you, this could have been a viable work-around for playing DX GotY under Proton.

Ingame colors look strange... Did anyone experience similar issues?

Yes, this is precisely why I haven't played DX under Proton.

OLucasZanella commented 2 years ago

Picked Deus Ex up today. I've only tried the start of the Training mission so far.

Only problem I've noticed so far with Proton Experimental and Software Rendering is that objects clip through surfaces. On ProtonDB, someone else had the same issues as me. Choosing the other option, it works as expected, except the colors now look exactly like on the screenshot @AsciiWolf provided.

Is there a known solution for this?

Edit: Proton-6.20-GE-1 corrects color issues with Direct3D, it's just quite darker than Software Rendering, brightness settings don't change anything.

deusex

Wedge009 commented 2 years ago

There seems to be a dilemma between bad colouring and a non-functioning brightness setting with recent Proton releases. Apparently the darkness is 'correct' but we are supposed to use other rendering options to 'improve' things. However, more recently I have noticed that the effectiveness of the brightness setting may be affected by playing in 'full screen' vs 'windowed mode' so that might be something else to check.

OLucasZanella commented 2 years ago

As far as I tested, full screen, windowed and borderless didn't change anything regarding brightness.

Wedge009 commented 2 years ago

Sorry, was going off memory. Maybe that only applies to the renderers in Revision, then.

FloFluoro commented 2 years ago

Hi, now that the Steam Deck is out and using out-of-game tweaks and fixes is less practical on that, I wanted to mention that the brightness and color issues are still a problem out of the box on the most recent version of Proton:

Direct3D renderer, Proton: image

Direct3D renderer, Windows: 20220327183043_1

zolstarym commented 1 year ago

I just tried the latest experimental on deus ex and unreal and the brightness seems to be working now. Tested with direct3d game engine